Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Apr 2, 2025

  • migrate to Angular 19 in this repo here so that we have traces of the Angular upgrade. The next step will be to move the entire project into Slickgrid-Universal repo, but I really wanted traces of the Angular 19 changes, so here it is
  • so as mentioned just above, I'm merging this into the next branch, even though this won't ever be used in here at all, because once this PR is valid and confirmed, we'll then be moving the project to Slickgrid-Universal

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7a5ea0e) to head (7ae577c).
Report is 1164 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##              next     #1554    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11         8     -3     
  Lines          920      1622   +702     
  Branches       304       464   +160     
==========================================
+ Hits           920      1622   +702     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding
Copy link
Owner Author

ghiscoding commented Apr 2, 2025

@zewa666 in this PR to upgrade to Angular 19, my last commit 19b0cf6 is about migrating to Vite/esbuild, is that all I need to use the new builder? I followed this migration: Angular application build system, I think it's ok the way I've done, but just wanted to confirm with a real user like you 😄

Also as mentioned above, this PR is really just for testing the Angular 19 upgrade and keeping traces, because the next step will be to use the content of this next branch and move it into Slickgrid-Universal (I know you are excited about this future move 😉 )

EDIT

hmm that's strange, with the new config, it looks like the index.html is inside the browser folder and I need to adjust my server to point to that new folder, is that expected? This will certainly screw up the GitHub live demo, since it expects to be in the root, not inside another folder... ahh I found this SO which helped me fix this non-sense website/browser folder

Also can we use the Vite preview in order to test the build? What I've done in the past (and still is in this PR) is to run a build and then I use servor (a small server util) to serve the build, but in other projects (like Vue, React) I simply use the Vite preview for that use case, is that available in Angular? I couldn't find it in the docs (though I guess I could use ng serve --no-hmr but that's probably not equal to Vite preview), my goal is to get rid of servor dep if I can do it with Vite preview instead

@ghiscoding ghiscoding merged commit ddfd26b into next Apr 3, 2025
4 checks passed
@ghiscoding ghiscoding deleted the feat/angular19 branch April 3, 2025 00:04
@ghiscoding
Copy link
Owner Author

alright, I found everything I wanted and it looks like I'm ready to merge and move ahead. Next step, moving it into Slickgrid-Universal 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants