-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ghostery Control Panel] create appealing landing for non-existing WTM Statistical report #1331
Comments
To avoid the current situation we should not show the link in the first place if we know there is no WTM page. We already are shipping a list of domain for which we have stats for the Trackers Preview. So I think it must be regression towards Ghostery 9. @smalluban can you take a look? @mdsandu are you fine to solve the problem by removing the link when there are no stats? If so, then this is pure engineering task. |
the button should be removed from the UI @chrmod |
on a second thought I think it brings more value to leave the page there(even if there is a solution to remove it) and populate it with great stats, great info about WTM and use it as a resource for users to learn more about WTM if they go to the panel anyways) |
Ok, so I leave it as it is. For the record, earlier we were checking if the page is not 404, but with the 5e2ac38#diff-a76932ae38751c82a862adaa5a488620ec81df9d0e049742a7af20d4d30b0e64L29 I removed that check (sorry, I can't remember why :P). |
most probably you removed the check because to trigger the stats in the control panel and create that link behind the button, the page must be loaded in the browser...can it be? |
let's hold this off until the census report is picked by the media. we can proceed then |
@kalinme the latest link is not working: https://www.figma.com/file/Ez4ZUl7q5yXVtAh17TZaOF/WhoTracks.Me?type=design&node-id=424%3A7215&mode=design&t=fkEX6NalaYYH9iqj-1 |
@mdsandu we need final decision about placeholder page. Discussion from yesterday: https://ghostery.slack.com/archives/C03MP7U2GJ0/p1709718902319209 |
AFAIR resolution was to check WTM data and not show the button when page is not in top 10K. correct me if I am wrong. but based on that this mini project became irrelevant |
We have already merged PR #1498 which hides the button if the WTM stats are missing, so I think we can remove the placeholder page, and show ordinary 404 if the user enters an invalid URL. |
|
Done |
we don't have the whole web in WTM, so many pages will not be found by users. let's make the landing visually appealing and informative for the user offering some of the new facts we created for WTM main page and linking out to somewhere to learn more about WTM
site like e.g.
https://www.whotracks.me/websites/whotracks.me.html
https://www.whotracks.me/websites/bisoubreton.com.html
starting point is:
now landing looks like:
The text was updated successfully, but these errors were encountered: