Skip to content

Commit b4afcd1

Browse files
authored
Bumping app package (#1341)
* Bumping app package * Bumping app further * Updating app package * Bumping app package to v7.0.4 * Fixing names
1 parent 2589e51 commit b4afcd1

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s
77

88
## [Unreleased]
99

10+
### Fixed
11+
12+
- Bump the `github.com/giantswarm/app` package to version `v7.0.4` which prevents creation of empty Secrets for Chart CRs.
13+
1014
## [7.0.0] - 2024-11-19
1115

1216
### Removed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ require (
88
github.com/Masterminds/semver/v3 v3.3.1
99
github.com/ghodss/yaml v1.0.0
1010
github.com/giantswarm/apiextensions-application v0.6.2
11-
github.com/giantswarm/app/v7 v7.0.3
11+
github.com/giantswarm/app/v7 v7.0.4
1212
github.com/giantswarm/appcatalog v1.0.0
1313
github.com/giantswarm/apptest v1.4.1
1414
github.com/giantswarm/backoff v1.0.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ github.com/ghodss/yaml v1.0.0 h1:wQHKEahhL6wmXdzwWG11gIVCkOv05bNOh+Rxn0yngAk=
131131
github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
132132
github.com/giantswarm/apiextensions-application v0.6.2 h1:XL86OrpprWl5Wp38EUvUXt3ztTo25+V63oDVlFwDpNg=
133133
github.com/giantswarm/apiextensions-application v0.6.2/go.mod h1:8ylqSmDSzFblCppRQTFo8v9s/F6MX6RTusVVoDDfWso=
134-
github.com/giantswarm/app/v7 v7.0.3 h1:2xMGts4kAkKHo4tUC8Golm3j/kAlUeQjAw5WpRkoz4w=
135-
github.com/giantswarm/app/v7 v7.0.3/go.mod h1:1xA1ddQzNMgPcf8VdQLn3Ohm2ww4z1ARSujirdFXz3U=
134+
github.com/giantswarm/app/v7 v7.0.4 h1:JBFKsUKhxtbduPVdBHjhGclg+czK7N7ITx4e3s9s4oQ=
135+
github.com/giantswarm/app/v7 v7.0.4/go.mod h1:szBwpNxf8NcxEGgmR+3ljEJEdKqe3Mfy5IcY5TEyf+s=
136136
github.com/giantswarm/appcatalog v1.0.0 h1:h2vNqd53ciYenoB04nrit4zruG4TeWiNT28t94l0wkw=
137137
github.com/giantswarm/appcatalog v1.0.0/go.mod h1:KmzfEU2sLoXldJ2OaAY6Pn/78h2wmfZqMwjRYQkudSo=
138138
github.com/giantswarm/apptest v1.4.1 h1:9GEVbB8Zvb/EdRXcmc2zWebs0TQ4pZrJ7W5XjnpDJS8=

service/controller/app/resource/secret/delete.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func (r *Resource) ApplyDeleteChange(ctx context.Context, obj, deleteChange inte
3131
} else if err != nil {
3232
return microerror.Mask(err)
3333
} else {
34-
r.logger.Debugf(ctx, "deleted Chart CR %#q in namespace %#q", secret.Name, secret.Namespace)
34+
r.logger.Debugf(ctx, "deleted secret %#q in namespace %#q", secret.Name, secret.Namespace)
3535
}
3636
}
3737

service/watcher/chartstatus/chartstatus.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ func (c *ChartStatusWatcher) watchChartStatus(ctx context.Context) {
163163
types.NamespacedName{Name: appName, Namespace: appNamespace},
164164
&app)
165165
if err != nil {
166-
c.logger.Errorf(ctx, err, "failed to get app '%s/%s'", app.Namespace, app.Name)
166+
c.logger.Errorf(ctx, err, "failed to get app '%s/%s'", appNamespace, appName)
167167
continue
168168
}
169169

0 commit comments

Comments
 (0)