Skip to content

Commit fbc99d2

Browse files
committed
add link to readthedocs, fix small issues
1 parent 53295fa commit fbc99d2

File tree

4 files changed

+17
-19
lines changed

4 files changed

+17
-19
lines changed

README.rst

+9-17
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,14 @@ but at the moment only Python 2.7 is supported.
1111
.. image:: https://travis-ci.org/gijzelaerr/python-snap7.png?branch=master
1212
:target: https://travis-ci.org/gijzelaerr/python-snap7
1313

14+
The full documentation is available on `Read The Docs <http://python-snap7.readthedocs.org/en/latest/>`_.
15+
1416

1517
Installation
1618
============
1719

18-
First install the snap7 library. You can download the source from the
19-
`snap7 website <http://snap7.sourceforge.net/>`_ and compile it, or if you use
20-
Ubuntu you can use the
21-
`Ubuntu packages <https://launchpad.net/~gijzelaar/+archive/snap7>`_ we created.
22-
23-
Next you can install the snap7 python rapper by running::
24-
25-
$ pip install python-snap7
26-
27-
28-
or when you install from source::
29-
30-
$ python setup.py install
31-
20+
Please read the
21+
`online installation documentation <http://python-snap7.readthedocs.org/en/latest/installation.html>`_.
3222

3323

3424
credits
@@ -37,8 +27,10 @@ credits
3727
- Gijs Molenaar
3828
- Stephan Preeker
3929

30+
4031
Special thanks to
4132
=================
42-
- Davide Nardella for creating snap7
43-
- Thomas Hergenhahn for his libnodave.
44-
- Thomas W for his S7comm wireshark plugin
33+
34+
- Davide Nardella for creating snap7
35+
- Thomas Hergenhahn for his libnodave.
36+
- Thomas W for his S7comm wireshark plugin

doc/development.rst

+8
Original file line numberDiff line numberDiff line change
@@ -38,3 +38,11 @@ server tests need to run as root. To run all tests please run::
3838
If the test complain about missing Python modules make sure the source directory
3939
is in your PYTHONPATH environment variable, or the python-snap7 module is
4040
installed.
41+
42+
Credits
43+
-------
44+
45+
python-snap7 is created by Gijs Molenaar and Stephan Preeker.
46+
47+
Special thanks to go to Davide Nardella for creating snap7, Thomas Hergenhahn
48+
for his libnodave and Thomas W for his S7comm wireshark plugin.
File renamed without changes.

snap7/server.py

-2
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,6 @@ def pick_event(self):
209209

210210
def get_param(self, number):
211211
"""Reads an internal Server object parameter.
212-
213-
int Srv_GetParam(S7Object Server, int ParamNumber, void *pValue);
214212
"""
215213
logger.debug("retreiving param number %s" % number)
216214
value = ctypes.c_int()

0 commit comments

Comments
 (0)