Refactoring

Author: gil9red

job_compassplus/parse_jira_Assigned_Open_Issues_per_Project/get_assigned_open_issues_per_project.py

@@ -19,6 +19,8 @@
 
 def get_assigned_open_issues_per_project() -> dict[str, int]:
     rs = session.get(URL)
+    rs.raise_for_status()
+
     root = BeautifulSoup(rs.content, "html.parser")
 
     data = dict()

job_compassplus/parse_jira_Assigned_Open_Issues_per_Project/gui.py

@@ -55,7 +55,8 @@ def log_uncaught_exceptions(ex_cls, ex, tb):
 sys.excepthook = log_uncaught_exceptions
 
 
-WINDOW_TITLE = DIR.name
+WINDOW_TITLE: str = DIR.name
+DATE_FORMAT: str = "%d/%m/%Y"
 
 
 def get_table_widget(header_labels: list) -> QTableWidget:
@@ -116,7 +117,7 @@ def refresh(self, items: list[Run]):
         for i, run in enumerate(items):
             self.table_run.setRowCount(self.table_run.rowCount() + 1)
 
-            item = QTableWidgetItem(run.date.strftime("%d/%m/%Y"))
+            item = QTableWidgetItem(run.date.strftime(DATE_FORMAT))
             item.setData(Qt.UserRole, run.get_project_by_issue_numbers())
             self.table_run.setItem(i, 0, item)
 
@@ -219,11 +220,11 @@ def refresh(self):
 
 
 class MyChartViewToolTips(ChartViewToolTips):
-    def __init__(self, timestamp_by_run: dict):
+    def __init__(self, timestamp_by_run: dict[int, Run]):
         super().__init__()
 
         self._callout_font_family = "Courier"
-        self.timestamp_by_run = timestamp_by_run
+        self.timestamp_by_run: dict[int, Run] = timestamp_by_run
 
     def show_series_tooltip(self, point, state: bool):
         # value -> pos
@@ -245,10 +246,16 @@ def show_series_tooltip(self, point, state: bool):
                     )
 
                     if current_distance < distance:
-                        date_value = int(p_value.x())
-                        run = self.timestamp_by_run[date_value]
+                        time_ms = int(p_value.x())
+                        run = self.timestamp_by_run[time_ms]
                         table = get_table(run.get_project_by_issue_numbers())
-                        text = f"Total issues: {run.get_total_issues()}\n\n{table}"
+                        text = (
+                            f"{date.fromtimestamp(time_ms / 1000).strftime(DATE_FORMAT)}"
+                            "\n\n"
+                            f"Total issues: {run.get_total_issues()}"
+                            "\n"
+                            f"{table}"
+                        )
 
                         self._tooltip.setText(text)
                         self._tooltip.setAnchor(p_value)
@@ -269,7 +276,7 @@ def __init__(self):
         icon = QIcon(file_name)
         self.setWindowIcon(icon)
 
-        self.timestamp_by_run = dict()
+        self.timestamp_by_run: dict[int, Run] = dict()
 
         menu = QMenu()
         menu.addAction("Show / hide", (lambda: self.setVisible(not self.isVisible())))