-
Notifications
You must be signed in to change notification settings - Fork 577
Open
Description
🐛 Bug Report
Custom overlay control issue in react-joyride when skipping the first step with a custom overlay implementation - callback function not executing.
Steps to Reproduce
- Set up react-joyride with disableOverlay={true}
- Implement custom overlay controlled by callback status
- Click skip button on first step
- Observe callback not firing
Current Behavior
- Callback function not executed when clicking skip on first step
- Custom overlay remains visible and uncontrollable
- Skip action changes internal status but doesn't trigger callback
Expected Behavior
- Callback should fire on skip action regardless of step position
- Custom overlay should be properly controlled through callback status
Additional Context
- Issue only occurs with custom overlay implementation
- Works as expected with default overlay disableOverlay={false}, (The overlay disappears, but the callback not being executed remains an issue.)
- Code analysis shows callback intentionally not fired when no previous step exists
- Need confirmation if intended behavior or bug
Environment
react-joyride version: 3.0.0-7
React version: 19.0.0
Next.js version: 15.1.2
Repository Link
https://github.com/JoonSukCho/react-joyride-example
Running the Code
yarn # install dependencies
yarn dev # run development server
CaioQuirinoMedeiros, hamidrezaghanbari, lukaskreibig, c-schicho, evanfurniss and 7 more
Metadata
Metadata
Assignees
Labels
No labels