Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier to standardize codebase #55

Merged
merged 4 commits into from
Aug 29, 2018
Merged

Add prettier to standardize codebase #55

merged 4 commits into from
Aug 29, 2018

Conversation

jason-fox
Copy link
Contributor

@jason-fox jason-fox commented Aug 28, 2018

Upgrades codebase to use ES6 const and let. Standardizes code format.

  • Add prettier to package.json
  • Run ESLint
  • Fix remaining errors

npm run lint fixes most errors and reports warnings.

npm test will start with a pretest lint run - I've not fixed the tests - currently fails since all files refer to config.js - (see #50 ) if the template is used then some tests will pass since the sanity tests rely on other microservices running

Copy link
Member

@aalonsog aalonsog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aalonsog aalonsog merged commit 19bb175 into ging:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants