Skip to content

Commit a99bfce

Browse files
committed
Changed function name
1 parent 405b74a commit a99bfce

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

src/Receiver.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void checkParts() {
3333
while (ttl && emptyParts.size() > 0) {
3434
for (auto index : emptyParts) {
3535
snprintf(buffer, 7, "RESEND"); //
36-
Utils::writeBytesFromInt(buffer + 6, index, 4); // Create request packet
36+
Utils::writeBytesFromNumber(buffer + 6, index, 4); // Create request packet
3737
sendto(_socket, buffer, 10, 0, (sockaddr*) &broadcast_address,//
3838
sizeof(broadcast_address)); //
3939

@@ -69,16 +69,16 @@ void run(cxxopts::ParseResult &options) {
6969
ttl = ttl_max; // Update ttl
7070

7171
if (strncmp(buffer, "NEW_PACKET", 10) == 0) {
72-
file_length = Utils::getIntFromBytes(buffer + 10, 4); // Read section "file length"
72+
file_length = Utils::getNumberFromBytes(buffer + 10, 4); // Read section "file length"
7373

7474
file = new char[file_length];
7575
memset(file, 0, file_length);
7676

7777
std::cout << "Receive information about new file size: " << file_length << std::endl;
7878
std::cout << "Number of parts: " << int((float)file_length / (float)mtu + 0.5) << std::endl;
7979
} else if (strncmp(buffer, "TRANSFER", 8) == 0) {
80-
int part = Utils::getIntFromBytes(buffer + 8, 4); // Read section "index"
81-
int size = Utils::getIntFromBytes(buffer + 12, 4); // Read section "size"
80+
int part = Utils::getNumberFromBytes(buffer + 8, 4); // Read section "index"
81+
int size = Utils::getNumberFromBytes(buffer + 12, 4); // Read section "size"
8282
parts.insert(part);
8383
std::cout << "Receive " << part << " part with size " << size << std::endl;
8484

src/Sender.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ void sendPart(int part_index) {
1616
if (packet_length > mtu) packet_length = mtu; //
1717

1818
snprintf(buffer, 9, "TRANSFER");
19-
Utils::writeBytesFromInt(buffer + 8, (size_t)part_index, 4); // Write section "number"
20-
Utils::writeBytesFromInt(buffer + 12, (size_t)packet_length, 4); // Write section "length"
19+
Utils::writeBytesFromNumber(buffer + 8, (size_t)part_index, 4); // Write section "number"
20+
Utils::writeBytesFromNumber(buffer + 12, (size_t)packet_length, 4); // Write section "length"
2121
memcpy(buffer + 16, (void *)(intptr_t)(file + part_index * mtu), packet_length); // Write section "data"
2222

2323
// Sending part to the broadcast address
@@ -49,7 +49,7 @@ void run(cxxopts::ParseResult &options) {
4949
std::cout << "Ok: File successfully copied to RAM" << std::endl;
5050

5151
snprintf(buffer, 11, "NEW_PACKET"); //
52-
Utils::writeBytesFromInt(buffer + 10, file_length, 4); // Sending information
52+
Utils::writeBytesFromNumber(buffer + 10, file_length, 4); // Sending information
5353
sendto(_socket, buffer, 14, 0, (sockaddr*) &broadcast_address, // about size of new file
5454
sizeof(broadcast_address)); //
5555

@@ -85,7 +85,7 @@ void run(cxxopts::ParseResult &options) {
8585
}
8686

8787
if (strncmp(buffer, "RESEND", 6) == 0) {
88-
int part = Utils::getIntFromBytes(buffer + 6, 4);
88+
int part = Utils::getNumberFromBytes(buffer + 6, 4);
8989

9090
auto now = std::chrono::system_clock::now();
9191
auto now_ms = std::chrono::time_point_cast<std::chrono::seconds>(now);

src/Utils.hpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ namespace Utils {
3737
* @param buffer - bytes array
3838
* @param count - bytes count
3939
*/
40-
int getIntFromBytes(char* buffer, int count) {
41-
int value = 0;
40+
size_t getNumberFromBytes(char* buffer, int count) {
41+
size_t number = 0;
4242
for (int i = 0; i < count; i++) {
43-
value = value << 8;
44-
value = value | (buffer[i] & 0xFF);
43+
number = number << 8;
44+
number = number | (buffer[i] & 0xFF);
4545
}
46-
return value;
46+
return number;
4747
}
4848

4949
/**
@@ -52,9 +52,9 @@ namespace Utils {
5252
* @param value - number
5353
* @param count - count bytes
5454
*/
55-
void writeBytesFromInt(char* buffer, size_t value, int count) {
55+
void writeBytesFromNumber(char* buffer, size_t number, int count) {
5656
for (int i = 0; i < count; i++) {
57-
buffer[count - i - 1] = (char) (value >> (i * 8));
57+
buffer[count - i - 1] = (char) (number >> (i * 8));
5858
}
5959
}
6060
}

0 commit comments

Comments
 (0)