update-all: use common infrastructure

Update 'update-all.go' to use 'common.FileSystem' to get the path to the
'git-bundle-server' executbale, and use 'cmd.CommandExecutor' to call
'git-bundle-server update'. The use of the common structures eliminate some
duplicate code as well as set up the command to be unit testable in the
future.

Signed-off-by: Victoria Dye <[email protected]>

Author: vdye

Diff for: cmd/git-bundle-server/update-all.go

@@ -2,11 +2,13 @@ package main
 
 import (
 	"context"
+	"fmt"
 	"os"
-	"os/exec"
 
 	"github.com/github/git-bundle-server/cmd/utils"
 	"github.com/github/git-bundle-server/internal/argparse"
+	"github.com/github/git-bundle-server/internal/cmd"
+	"github.com/github/git-bundle-server/internal/common"
 	"github.com/github/git-bundle-server/internal/core"
 	"github.com/github/git-bundle-server/internal/log"
 )
@@ -37,13 +39,15 @@ func (u *updateAllCmd) Run(ctx context.Context, args []string) error {
 	parser.Parse(ctx, args)
 
 	repoProvider := utils.GetDependency[core.RepositoryProvider](ctx, u.container)
+	fileSystem := utils.GetDependency[common.FileSystem](ctx, u.container)
+	commandExecutor := utils.GetDependency[cmd.CommandExecutor](ctx, u.container)
 
 	repos, err := repoProvider.GetRepositories(ctx)
 	if err != nil {
 		return u.logger.Error(ctx, err)
 	}
 
-	exe, err := os.Executable()
+	exe, err := fileSystem.GetLocalExecutable("git-bundle-server")
 	if err != nil {
 		return u.logger.Errorf(ctx, "failed to get path to execuable: %w", err)
 	}
@@ -53,19 +57,13 @@ func (u *updateAllCmd) Run(ctx context.Context, args []string) error {
 
 	for route := range repos {
 		subargs[1] = route
-		cmd := exec.Command(exe, subargs...)
-		cmd.Stderr = os.Stderr
-		cmd.Stdout = os.Stdout
-
-		err := cmd.Start()
-		if err != nil {
-			return u.logger.Errorf(ctx, "git command failed to start: %w", err)
-		}
-
-		err = cmd.Wait()
+		exitCode, err := commandExecutor.Run(ctx, exe, subargs, cmd.Stdout(os.Stdout), cmd.Stderr(os.Stderr))
 		if err != nil {
-			return u.logger.Errorf(ctx, "git command returned a failure: %w", err)
+			return u.logger.Error(ctx, err)
+		} else if exitCode != 0 {
+			return u.logger.Errorf(ctx, "git-bundle-server update exited with status %d", exitCode)
 		}
+		fmt.Print("\n")
 	}
 
 	return nil