init: exit with error if route already exists

If 'init' tries to initialize a new route, but that route already exists on
disk (enabled or not), exit with an error. Without this explicit check, the
initialization will fail anyway (specifically, the bare repo clone), but the
call to 'RepositoryProvider.CreateRepository()' will enable the existing
route even if it was disabled. To avoid that unintended behavior and provide
clearer information to users, explicitly check for existing routes before
'CreateRepository()' and exit if the route already exists.

Signed-off-by: Victoria Dye <[email protected]>

Author: vdye

cmd/git-bundle-server/init.go

@@ -53,6 +53,18 @@ func (i *initCmd) Run(ctx context.Context, args []string) error {
 	bundleProvider := utils.GetDependency[bundles.BundleProvider](ctx, i.container)
 	gitHelper := utils.GetDependency[git.GitHelper](ctx, i.container)
 
+	// First, check whether route already exists (enabled or not). If it does,
+	// exit with an error.
+	allRepos, err := repoProvider.ReadRepositoryStorage(ctx)
+	if err != nil {
+		return i.logger.Errorf(ctx, "could not load existing routes: %w", err)
+	} else if _, ok := allRepos[*route]; ok {
+		return i.logger.Errorf(ctx, "route '%s' already exists; if you want to "+
+			"overwrite the route, delete it with 'git-bundle-server delete' "+
+			"then re-run this command", *route)
+	}
+
+	// Create the new route
 	repo, err := repoProvider.CreateRepository(ctx, *route)
 	if err != nil {
 		return i.logger.Error(ctx, err)