github-release: remove v2.46.1 work-around

The deployment of the v2.46.1 release originally did not work. The
reason was that the GitForWindowsHelper GitHub App lacked the
permissions to create Discussions.

This has been fixed in the meantime, the deployment was completed, and
now we can remove the work-around that allowed us to resume the failed
deployment.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

.github/actions/github-release/action.yml

@@ -63,8 +63,6 @@ runs:
         text: "For details, see [this run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id}})."
         details-url: "https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id}}"
     - name: Download bundle-artifacts (needed to push the tag)
-      # allow resuming failed deployment
-      if: inputs.tag-name != 'v2.46.1.windows.1'
       uses: actions/download-artifact@v4
       with:
         name: bundle-artifacts
@@ -91,12 +89,7 @@ runs:
             ${{ toJSON(inputs.private-key) }},
             '${{ inputs.owner }}',
             '${{ inputs.repo }}')
-          await state.refreshToken()
 
-          let release
-          if ('${{ inputs.tag-name }}' === 'v2.46.1.windows.1') {
-            release = { id: 175612508 }
-          } else {
           const [ artifactsOwner, artifactsRepo ] = '${{ inputs.artifacts-repository }}'.split('/')
           const artifacts = await getGitArtifacts(
             console,
@@ -110,7 +103,8 @@ runs:
           const sha256sums = sha256sumsFromReleaseNotes(${{ toJSON(inputs.release-notes) }})
           await checkSHA256Sums(console, artifacts, sha256sums)
 
-          release = await createRelease(
+          await state.refreshToken()
+          const release = await createRelease(
             console,
             state.accessToken,
             '${{ inputs.owner }}',
@@ -156,7 +150,6 @@ runs:
               make_latest : !isPrerelease,
             }
           )
-          }
 
           try {
             await state.refreshToken()