Skip to content

Commit

Permalink
build-and-deploy: work around curl v8.11.0 bug
Browse files Browse the repository at this point in the history
In order to deploy the bug fix for curl, we need to work around the bug
that this fix addresses... because the bug breaks the deployment of all
MSYS2-packages, including `libcurl`.

Let's work around this by downgrading `libcurl` specifically for this
deployment.

See git-for-windows/MSYS2-packages#199 for more
details.

Signed-off-by: Johannes Schindelin <[email protected]>
  • Loading branch information
dscho committed Nov 14, 2024
1 parent f91558b commit 32b3e09
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions .github/workflows/build-and-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,30 @@ jobs:
architecture: ${{ env.ARCHITECTURE || 'x86_64' }}
msys: ${{ env.REPO == 'MSYS2-packages' || env.PACKAGE_TO_BUILD == 'git-for-windows-keyring' }}

- name: work around curl v8.11.0-1 problem
if: env.PACKAGE_TO_BUILD == 'curl' && env. REF == 'd58b04ae4163fe6c6c25b330bea0930d7bb627ac'
shell: bash
run: |
# `git fetch` does not work with that libcurl version. For details,
# see https://github.com/git-for-windows/MSYS2-packages/pull/199
test ! -f /var/lib/pacman/local/libcurl-8.11.0-1/desc ||
for pkg in libcurl curl
do
case "$ARCHITECTURE" in
i686) url=https://wingit.blob.core.windows.net/i686/$pkg-8.10.1-1-i686.pkg.tar.xz;;
x86_64) url=https://wingit.blob.core.windows.net/x86-64/$pkg-8.10.1-1-x86_64.pkg.tar.xz;;
esac
for suffix in '' .sig
do
curl --retry 5 -fLO $url$suffix || exit 1
done
pacman -U --noconfirm ${url##*/} || exit 1
done
# Sadly, this does not work because the Pacman repository's index only
# ever lists the latest package version:
# pacman -S --noconfirm libcurl=8.10.1-1 curl=8.10.1-1
- name: Clone ${{ env.REPO }}
shell: bash
run: |
Expand Down

0 comments on commit 32b3e09

Please sign in to comment.