cleanup-self-hosted-runner: order the conditional blocks from small to large

In general, if..else..fi constructs are more readable when the first
block is shorter than the second, i.e. to handle the "easy" things
first; According to Cognitive Load Theory, this uses less mental
resources when wrapping our head around the code.

In this instance, there is an even better reason: The next commit will
add _another_ condition, and having it in this order will avoid adding
another nesting level:

	if too young
		skip
	else if busy
		skip
	else
		force delete VM
	fi

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

.github/workflows/cleanup-self-hosted-runners.yml

@@ -44,13 +44,13 @@ jobs:
               vm_creation_iso_string=$(echo $active_vm | jq -r '.timeCreated')
               vm_creation_time=$(date -d $vm_creation_iso_string +%s)
               
-              if [ "$three_hours_ago" -ge "$vm_creation_time" ]; then
+              if [ "$three_hours_ago" -lt "$vm_creation_time" ]; then
+                  echo "The VM ${vm_name} was created less then 3 hours ago and shouldn't be deleted yet. Skipping."
+              else
                   echo "The VM ${vm_name} was created more than 3 hours ago and wasn't deleted. Let's do that now."
                   az vm delete -n "$vm_name" -g ${{ secrets.AZURE_RESOURCE_GROUP }} --yes
                   az network nsg delete -n "$vm_name"-nsg -g ${{ secrets.AZURE_RESOURCE_GROUP }}
                   az network vnet delete -n "$vm_name"-vnet -g ${{ secrets.AZURE_RESOURCE_GROUP }}
                   az network public-ip delete -n "$vm_name"-ip -g ${{ secrets.AZURE_RESOURCE_GROUP }}
-              else
-                  echo "The VM ${vm_name} was created less then 3 hours ago and shouldn't be deleted yet. Skipping."
               fi
           done