Skip to content

Commit 78ba988

Browse files
kbleesdscho
authored andcommitted
Win32: implement basic symlink() functionality (file symlinks only)
Implement symlink() that always creates file symlinks. Fails with ENOSYS if symlinks are disabled or unsupported. Note: CreateSymbolicLinkW() was introduced with symlink support in Windows Vista. For compatibility with Windows XP, we need to load it dynamically and fail gracefully if it isnt's available. Signed-off-by: Karsten Blees <[email protected]>
1 parent 99d1d87 commit 78ba988

File tree

2 files changed

+29
-2
lines changed

2 files changed

+29
-2
lines changed

compat/mingw.c

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2764,6 +2764,34 @@ int link(const char *oldpath, const char *newpath)
27642764
return 0;
27652765
}
27662766

2767+
int symlink(const char *target, const char *link)
2768+
{
2769+
wchar_t wtarget[MAX_LONG_PATH], wlink[MAX_LONG_PATH];
2770+
int len;
2771+
2772+
/* fail if symlinks are disabled or API is not supported (WinXP) */
2773+
if (!has_symlinks) {
2774+
errno = ENOSYS;
2775+
return -1;
2776+
}
2777+
2778+
if ((len = xutftowcs_long_path(wtarget, target)) < 0
2779+
|| xutftowcs_long_path(wlink, link) < 0)
2780+
return -1;
2781+
2782+
/* convert target dir separators to backslashes */
2783+
while (len--)
2784+
if (wtarget[len] == '/')
2785+
wtarget[len] = '\\';
2786+
2787+
/* create file symlink */
2788+
if (!CreateSymbolicLinkW(wlink, wtarget, 0)) {
2789+
errno = err_win_to_posix(GetLastError());
2790+
return -1;
2791+
}
2792+
return 0;
2793+
}
2794+
27672795
#ifndef _WINNT_H
27682796
/*
27692797
* The REPARSE_DATA_BUFFER structure is defined in the Windows DDK (in

compat/mingw.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,6 @@ struct utsname {
125125
* trivial stubs
126126
*/
127127

128-
static inline int symlink(const char *oldpath UNUSED, const char *newpath UNUSED)
129-
{ errno = ENOSYS; return -1; }
130128
static inline int fchmod(int fildes UNUSED, mode_t mode UNUSED)
131129
{ errno = ENOSYS; return -1; }
132130
#ifndef __MINGW64_VERSION_MAJOR
@@ -220,6 +218,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out);
220218
int sigaction(int sig, struct sigaction *in, struct sigaction *out);
221219
int link(const char *oldpath, const char *newpath);
222220
int uname(struct utsname *buf);
221+
int symlink(const char *target, const char *link);
223222
int readlink(const char *path, char *buf, size_t bufsiz);
224223

225224
/*

0 commit comments

Comments
 (0)