Skip to content

Commit ceeecb0

Browse files
committed
Merge branch 'support-azure-ad-users-again'
As of the upgrade to v3.6.2, I can no longer open any MinTTY windows: It errors out with the message "Error: Could not fork child process: There are no available terminals (-1)". This symptom was also described on the Cygwin mailing list: https://inbox.sourceware.org/cygwin/CAL148o6i=r+G=cEQzs5e+KmMt07FxJHhMnoNnquhM0JJuyrwtA@mail.gmail.com/#t I've bisected the problem down to 48e7d63 (Cygwin: fetch_account_from_windows: skip LookupAccountSid for SIDs known to fail, 2025-04-10), which prevents my AzureAD user account (the SID begins with `S-1-12-1-`) from being handled correctly. This PR is a (minimally) partial revert of that commit to resolve this problem. Signed-off-by: Johannes Schindelin <[email protected]>
2 parents 0b9a01b + 1a222c8 commit ceeecb0

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

winsup/cygwin/uinfo.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2002,10 +2002,6 @@ pwdgrp::fetch_account_from_windows (fetch_user_arg_t &arg, cyg_ldap *pldap)
20022002
if (sid_id_auth (sid) == 5 /* SECURITY_NT_AUTHORITY */
20032003
&& sid_sub_auth (sid, 0) == SECURITY_APPPOOL_ID_BASE_RID)
20042004
break;
2005-
/* AzureAD SIDs */
2006-
if (sid_id_auth (sid) == 12 /* AzureAD ID */
2007-
&& sid_sub_auth (sid, 0) == 1 /* Azure ID base RID */)
2008-
break;
20092005
/* Samba user/group SIDs */
20102006
if (sid_id_auth (sid) == 22)
20112007
break;

0 commit comments

Comments
 (0)