Skip to content

Commit 31fb5f7

Browse files
authored
Use default branch instead of master (#32)
* use default branch instead of hard coded master * ignore .bsp
1 parent 1d72ca6 commit 31fb5f7

File tree

5 files changed

+17
-14
lines changed

5 files changed

+17
-14
lines changed

.gitignore

+2-1
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,5 @@ project/plugins/project/
2828
.bloop/
2929
.metals/
3030
.vscode/
31-
**/metals.sbt
31+
**/metals.sbt
32+
.bsp

src/main/scala/Plugin.scala

+2-3
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,8 @@ class Plugin extends gitbucket.core.plugin.Plugin {
3939

4040
override val controllers: Seq[(String, ControllerBase)] = Seq("/*" -> new PagesController)
4141

42-
override val repositorySettingTabs = Seq(
43-
(repository: RepositoryInfo, context: Context) => Some(Link("pages", "Pages", s"settings/pages"))
44-
)
42+
override val repositorySettingTabs =
43+
Seq((repository: RepositoryInfo, context: Context) => Some(Link("pages", "Pages", s"settings/pages")))
4544

4645
override val repositoryHooks = Seq(new PagesHook)
4746
}

src/main/scala/gitbucket/plugin/pages/pages.scala

+7-5
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ trait PagesControllerBase extends ControllerBase {
3030
self: AccountService with RepositoryService with PagesService with ReferrerAuthenticator with OwnerAuthenticator =>
3131
import PagesControllerBase._
3232

33-
val optionsForm = mapping("source" -> trim(label("Pages Source", text(required, pagesOption))))(
34-
(source) => OptionsForm(PageSourceType.valueOf(source))
33+
val optionsForm = mapping("source" -> trim(label("Pages Source", text(required, pagesOption))))((source) =>
34+
OptionsForm(PageSourceType.valueOf(source))
3535
)
3636

3737
val PAGES_BRANCHES = List("gb-pages", "gh-pages")
@@ -45,14 +45,15 @@ trait PagesControllerBase extends ControllerBase {
4545
})
4646

4747
private def renderPage(repository: RepositoryInfo, path: String) = {
48+
val defaultBranch = repository.repository.defaultBranch
4849
Using.resource(Git.open(Directory.getRepositoryDir(repository.owner, repository.name))) { git =>
4950
getPageSource(repository.owner, repository.name) match {
5051
case PageSourceType.GH_PAGES =>
5152
renderFromBranch(repository, git, path, PAGES_BRANCHES.collectFirstOpt(resolveBranch(git, _)))
5253
case PageSourceType.MASTER =>
53-
renderFromBranch(repository, git, path, resolveBranch(git, "master"))
54+
renderFromBranch(repository, git, path, resolveBranch(git, defaultBranch))
5455
case PageSourceType.MASTER_DOCS =>
55-
renderFromBranch(repository, git, joinPath("docs", path), resolveBranch(git, "master"))
56+
renderFromBranch(repository, git, joinPath("docs", path), resolveBranch(git, defaultBranch))
5657
case PageSourceType.NONE =>
5758
NotFound()
5859
}
@@ -61,7 +62,8 @@ trait PagesControllerBase extends ControllerBase {
6162

6263
get("/:owner/:repository/settings/pages")(ownerOnly { repository =>
6364
val source = getPageSource(repository.owner, repository.name)
64-
html.options(repository, source, flash.get("info"))
65+
val defaultBranch = repository.repository.defaultBranch
66+
html.options(repository, source, defaultBranch, flash.get("info"))
6567
})
6668

6769
post("/:owner/:repository/settings/pages", optionsForm)(ownerOnly { (form, repository) =>

src/main/scala/gitbucket/plugin/service/PagesService.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ trait PagesService {
2121
.map(t => t.source)
2222
.update(source)
2323

24-
def renameRepository(userName: String, oldRepositoryName: String, newRepositoryName: String)(
25-
implicit s: Session
24+
def renameRepository(userName: String, oldRepositoryName: String, newRepositoryName: String)(implicit
25+
s: Session
2626
): Unit =
2727
Pages
2828
.filter(t => (t.userName === userName.bind) && (t.repositoryName === oldRepositoryName.bind))

src/main/twirl/gitbucket/pages/options.scala.html

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
@import gitbucket.plugin.model.PageSourceType
22
@(repository: gitbucket.core.service.RepositoryService.RepositoryInfo,
33
source: PageSourceType,
4+
defaultBranch: String,
45
info: Option[Any])(implicit context: gitbucket.core.controller.Context)
56
@import gitbucket.core.view.helpers
67
@gitbucket.core.html.main("Pages", Some(repository)){
@@ -24,16 +25,16 @@
2425
<div class="radio">
2526
<label>
2627
<input type="radio" name="source" value="@PageSourceType.MASTER.code" @if(source == PageSourceType.MASTER) { checked="checked" }>
27-
<span class="strong">master branch</span><br>
28+
<span class="strong">default branch</span><br>
2829
<div class="normal muted">
29-
Use the <code>master</code> branch for Pages.
30+
Use the <code>@defaultBranch</code> branch for Pages.
3031
</div>
3132
</label>
3233
</div>
3334
<div class="radio">
3435
<label>
3536
<input type="radio" name="source" value="@PageSourceType.MASTER_DOCS.code" @if(source == PageSourceType.MASTER_DOCS) { checked="checked" }>
36-
<span class="strong">master branch /docs folder</span><br>
37+
<span class="strong">default branch /docs folder</span><br>
3738
<div class="normal muted">
3839
Use only the <code>/docs</code> folder for Pages.
3940
</div>

0 commit comments

Comments
 (0)