Merge pull request #1992 from gitgitgadget/fix-misleading-parsePRURLInput-error-message

webstech · web-flow · commit d8a4e4788240 · 2025-09-01T16:52:24.000-07:00
CIHelper.parsePRURLInput: fix misleading error message
diff --git a/lib/ci-helper.ts b/lib/ci-helper.ts
@@ -263,12 +263,11 @@ export class CIHelper {
     }
 
     public parsePRURLInput(): { owner: string; repo: string; prNumber: number } {
-        const prCommentUrl = core.getInput("pr-url");
+        const prUrl = core.getInput("pr-url");
 
-        const [, owner, repo, prNumber] =
-            prCommentUrl.match(/^https:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)$/) || [];
+        const [, owner, repo, prNumber] = prUrl.match(/^https:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)$/) || [];
         if (!this.config.repo.owners.includes(owner) || repo !== this.config.repo.name) {
-            throw new Error(`Invalid PR comment URL: ${prCommentUrl}`);
+            throw new Error(`Invalid PR URL: ${prUrl}`);
         }
         return { owner, repo, prNumber: parseInt(prNumber, 10) };
     }

Original file line number	Diff line number	Diff line change
`@@ -263,12 +263,11 @@ export class CIHelper {`
`263`	`263`	`}`
`264`	`264`
`265`	`265`	`public parsePRURLInput(): { owner: string; repo: string; prNumber: number } {`
`266`		`- const prCommentUrl = core.getInput("pr-url");`
	`266`	`+ const prUrl = core.getInput("pr-url");`
`267`	`267`
`268`		`- const [, owner, repo, prNumber] =`
`269`		`- prCommentUrl.match(/^https:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)$/) \|\| [];`
	`268`	`+ const [, owner, repo, prNumber] = prUrl.match(/^https:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)$/) \|\| [];`
`270`	`269`	`if (!this.config.repo.owners.includes(owner) \|\| repo !== this.config.repo.name) {`
`271`		- throw new Error(`Invalid PR comment URL: ${prCommentUrl}`);
	`270`	+ throw new Error(`Invalid PR URL: ${prUrl}`);
`272`	`271`	`}`
`273`	`272`	`return { owner, repo, prNumber: parseInt(prNumber, 10) };`
`274`	`273`	`}`