Skip to content

Commit ea34b1a

Browse files
committed
review comments
1 parent b5a9410 commit ea34b1a

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

.github/workflows/packer-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
name: Verify packer
1717
runs-on: ubuntu-latest
1818
container:
19-
image: index.docker.io/hashicorp/packer@sha256:297bbbbbbf3ce9e0431ac1e8f02934b20e1197613f877b55dfdb1ebfd94eb748 # ratchet:index.docker.io/hashicorp/packer:1.8.6
19+
image: index.docker.io/hashicorp/packer@sha256:12c441b8a3994e7df9f0e2692d9298f14c387e70bcc06139420977dbf80a137b # 1.11.2
2020
strategy:
2121
matrix:
2222
image: ["linux-al2023", "windows-core-2019", "windows-core-2022", "ubuntu-focal", "ubuntu-jammy", "ubuntu-jammy-arm64"]

.github/workflows/release.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,11 @@ jobs:
2222
working-directory: lambdas
2323
run: yarn install --frozen-lockfile && yarn run test && yarn dist
2424
- name: Get installation token
25-
uses: philips-software/app-token-action@9f5d57062c9f2beaffafaa9a34f66f824ead63a9 # ratchet:philips-software/[email protected]
25+
uses: actions/create-github-app-token@31c86eb3b33c9b601a1f60f98dcbfd1d70f379b4 # v1.10.3
2626
id: token
2727
with:
28-
app_id: ${{ secrets.FOREST_RELEASER_APP_ID }}
29-
app_base64_private_key: ${{ secrets.FOREST_RELEASER_APP_PRIVATE_KEY_BASE64 }}
30-
auth_type: installation
28+
app-id: ${{ secrets.FOREST_RELEASER_APP_ID }}
29+
private-key: ${{ secrets.FOREST_RELEASER_APP_PRIVATE_KEY }}
3130
- name: Extract branch name
3231
id: branch
3332
shell: bash
@@ -36,7 +35,7 @@ jobs:
3635
id: release
3736
uses: google-github-actions/release-please-action@e4dc86ba9405554aeba3c6bb2d169500e7d3b4ee # v4.1.1
3837
with:
39-
default-branch: ${{ steps.branch.outputs.name }}
38+
target-branch: ${{ steps.branch.outputs.name }}
4039
release-type: terraform-module
4140
token: ${{ steps.token.outputs.token }}
4241
- name: Upload Release Asset

.github/workflows/update-docs.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ jobs:
1616
runs-on: ubuntu-latest
1717
steps:
1818
- name: Checkout with GITHUB Action token
19-
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # ratchet:actions/checkout@v4
19+
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
2020
with:
2121
token: ${{ secrets.GITHUB_TOKEN }}
2222

2323
# use an app to ensure CI is triggered
2424
- name: Generate TF docs
2525
if: github.repository_owner == 'philips-labs'
26-
uses: terraform-docs/gh-actions@e47bfa196e79fa50987ef391be236d9d97b0c786 # ratchet:terraform-docs/gh-actions@v1.2.0
26+
uses: terraform-docs/gh-actions@e47bfa196e79fa50987ef391be236d9d97b0c786 # v1.2.0
2727
with:
2828
find-dir: .
2929
git-commit-message: "docs: auto update terraform docs"
@@ -33,7 +33,7 @@ jobs:
3333

3434
- name: Generate TF docs (forks)
3535
if: github.repository_owner != 'philips-labs'
36-
uses: terraform-docs/gh-actions@e47bfa196e79fa50987ef391be236d9d97b0c786 # ratchet:terraform-docs/gh-actions@v1.2.0
36+
uses: terraform-docs/gh-actions@e47bfa196e79fa50987ef391be236d9d97b0c786 # v1.2.0
3737
with:
3838
find-dir: .
3939
git-commit-message: "docs: auto update terraform docs"
@@ -42,7 +42,7 @@ jobs:
4242
# change docs via PR in case of locked main branch
4343
- name: Create Pull Request (main branch only)
4444
if: github.ref == 'refs/heads/main' && github.repository_owner == 'philips-labs'
45-
uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c # ratchet:peter-evans/create-pull-request@v6.1.0
45+
uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c # v6.1.0
4646
with:
4747
token: ${{ secrets.GITHUB_TOKEN }}
4848
commit-message: "docs: auto update terraform docs"
@@ -56,16 +56,16 @@ jobs:
5656
needs: [docs]
5757
runs-on: ubuntu-latest
5858
steps:
59-
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # ratchet:actions/checkout@v4
59+
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
6060
- name: Configure Git Credentials
6161
run: |
6262
git config user.name github-actions[bot]
6363
git config --global user.email "github-actions[bot]@users.noreply.github.com"
64-
- uses: actions/setup-python@v5
64+
- uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
6565
with:
6666
python-version: 3.x
6767
- run: echo "cache_id=$(date --utc '+%V')" >> $GITHUB_ENV
68-
- uses: actions/cache@v4
68+
- uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
6969
with:
7070
key: mkdocs-material-${{ env.cache_id }}
7171
path: .cache

0 commit comments

Comments
 (0)