Skip to content

Commit 16bfd28

Browse files
authored
Merge pull request #810 from github/codeql/upgrade-to-2.18.4
Upgrade `github/codeql` dependency to 2.18.4
2 parents 7b72e6c + 20a0120 commit 16bfd28

File tree

213 files changed

+683
-370
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

213 files changed

+683
-370
lines changed

Diff for: c/cert/src/codeql-pack.lock.yml

+13-7
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,23 @@
22
lockVersion: 1.0.0
33
dependencies:
44
codeql/cpp-all:
5-
version: 0.12.9
5+
version: 1.4.2
66
codeql/dataflow:
7-
version: 0.2.3
7+
version: 1.1.1
8+
codeql/mad:
9+
version: 1.0.7
810
codeql/rangeanalysis:
9-
version: 0.0.11
11+
version: 1.0.7
1012
codeql/ssa:
11-
version: 0.2.12
13+
version: 1.0.7
1214
codeql/tutorial:
13-
version: 0.2.12
15+
version: 1.0.7
16+
codeql/typeflow:
17+
version: 1.0.7
1418
codeql/typetracking:
15-
version: 0.2.12
19+
version: 1.0.7
1620
codeql/util:
17-
version: 0.2.12
21+
version: 1.0.7
22+
codeql/xml:
23+
version: 1.0.7
1824
compiled: false

Diff for: c/cert/src/qlpack.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ suites: codeql-suites
55
license: MIT
66
dependencies:
77
codeql/common-c-coding-standards: '*'
8-
codeql/cpp-all: 0.12.9
8+
codeql/cpp-all: 1.4.2

Diff for: c/cert/src/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import cpp
1515
import codingstandards.c.cert
16-
import codingstandards.cpp.dataflow.DataFlow
16+
import semmle.code.cpp.dataflow.DataFlow
1717
import NonArrayPointerToArrayIndexingExprFlow::PathGraph
1818

1919
/**

Diff for: c/cert/src/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import cpp
1515
import codingstandards.c.cert
1616
import codingstandards.cpp.Pointers
17-
import codingstandards.cpp.dataflow.TaintTracking
17+
import semmle.code.cpp.dataflow.TaintTracking
1818
import ScaledIntegerPointerArithmeticFlow::PathGraph
1919

2020
/**

Diff for: c/cert/src/rules/CON30-C/CleanUpThreadSpecificStorage.ql

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
import cpp
1616
import codingstandards.c.cert
1717
import codingstandards.cpp.Concurrency
18-
import codingstandards.cpp.dataflow.TaintTracking
19-
import codingstandards.cpp.dataflow.DataFlow
18+
import semmle.code.cpp.dataflow.TaintTracking
19+
import semmle.code.cpp.dataflow.DataFlow
2020

2121
module TssCreateToTssDeleteConfig implements DataFlow::ConfigSig {
2222
predicate isSource(DataFlow::Node node) {

Diff for: c/cert/src/rules/CON34-C/AppropriateThreadObjectStorageDurations.ql

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
import cpp
1616
import codingstandards.c.cert
1717
import codingstandards.cpp.Concurrency
18-
import codingstandards.cpp.dataflow.TaintTracking
19-
import codingstandards.cpp.dataflow.DataFlow
18+
import semmle.code.cpp.dataflow.TaintTracking
19+
import semmle.code.cpp.dataflow.DataFlow
2020
import semmle.code.cpp.commons.Alloc
2121

2222
from C11ThreadCreateCall tcc, StackVariable sv, Expr arg, Expr acc

Diff for: c/cert/src/rules/CON34-C/ThreadObjectStorageDurationsNotInitialized.ql

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
import cpp
1717
import codingstandards.c.cert
1818
import codingstandards.cpp.Concurrency
19-
import codingstandards.cpp.dataflow.TaintTracking
20-
import codingstandards.cpp.dataflow.DataFlow
19+
import semmle.code.cpp.dataflow.TaintTracking
20+
import semmle.code.cpp.dataflow.DataFlow
2121

2222
from TSSGetFunctionCall tsg, ThreadedFunction tf
2323
where

Diff for: c/cert/src/rules/DCL30-C/AppropriateStorageDurationsFunctionReturn.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import cpp
1515
import codingstandards.c.cert
16-
import codingstandards.cpp.dataflow.DataFlow
16+
import semmle.code.cpp.dataflow.DataFlow
1717

1818
class Source extends StackVariable {
1919
Source() { not this instanceof Parameter }

Diff for: c/cert/src/rules/ERR30-C/FunctionCallBeforeErrnoCheck.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import cpp
1515
import codingstandards.c.cert
1616
import codingstandards.c.Errno
17-
import codingstandards.cpp.dataflow.DataFlow
17+
import semmle.code.cpp.dataflow.DataFlow
1818

1919
/**
2020
* A call to an `OutOfBandErrnoSettingFunction`

Diff for: c/cert/src/rules/EXP30-C/DependenceOnOrderOfFunctionArgumentsForSideEffects.ql

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import cpp
1515
import codingstandards.c.cert
1616
import codingstandards.cpp.SideEffect
17-
import codingstandards.cpp.dataflow.DataFlow
18-
import codingstandards.cpp.dataflow.TaintTracking
17+
import semmle.code.cpp.dataflow.DataFlow
18+
import semmle.code.cpp.dataflow.TaintTracking
1919
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
2020

2121
/** Holds if the function's return value is derived from the `AliasParamter` p. */

Diff for: c/cert/src/rules/EXP36-C/DoNotCastPointerToMoreStrictlyAlignedPointerType.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import cpp
1515
import codingstandards.c.cert
1616
import codingstandards.cpp.Alignment
17-
import codingstandards.cpp.dataflow.DataFlow
17+
import semmle.code.cpp.dataflow.DataFlow
1818
import semmle.code.cpp.rangeanalysis.SimpleRangeAnalysis
1919
import ExprWithAlignmentToCStyleCastFlow::PathGraph
2020

Diff for: c/cert/src/rules/EXP37-C/DoNotCallFunctionPointerWithIncompatibleType.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import cpp
1515
import codingstandards.c.cert
16-
import codingstandards.cpp.dataflow.DataFlow
16+
import semmle.code.cpp.dataflow.DataFlow
1717
import SuspectFunctionPointerToCallFlow::PathGraph
1818

1919
/**

Diff for: c/cert/src/rules/EXP39-C/DoNotAccessVariableViaPointerOfIncompatibleType.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import cpp
1515
import codingstandards.c.cert
16-
import codingstandards.cpp.dataflow.DataFlow
16+
import semmle.code.cpp.dataflow.DataFlow
1717
import semmle.code.cpp.controlflow.Dominance
1818
import IndirectCastFlow::PathGraph
1919

Diff for: c/cert/src/rules/EXP40-C/DoNotModifyConstantObjects.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
import cpp
1414
import codingstandards.c.cert
15-
import codingstandards.cpp.dataflow.DataFlow
15+
import semmle.code.cpp.dataflow.DataFlow
1616
import CastFlow::PathGraph
1717
import codingstandards.cpp.SideEffect
1818

Diff for: c/cert/src/rules/EXP43-C/RestrictPointerReferencesOverlappingObject.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
*/
1212

1313
import cpp
14-
import codingstandards.cpp.dataflow.DataFlow
14+
import semmle.code.cpp.dataflow.DataFlow
1515
import semmle.code.cpp.controlflow.Dominance
1616
import codingstandards.c.cert
1717
import codingstandards.cpp.Variable

Diff for: c/cert/src/rules/FIO37-C/SuccessfulFgetsOrFgetwsMayReturnAnEmptyString.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import cpp
1414
import codingstandards.c.cert
1515
import codingstandards.cpp.FgetsErrorManagement
1616
import codingstandards.cpp.Dereferenced
17-
import codingstandards.cpp.dataflow.TaintTracking
17+
import semmle.code.cpp.dataflow.TaintTracking
1818

1919
/*
2020
* CFG nodes that follows a successful call to `fgets`

Diff for: c/cert/src/rules/FIO44-C/OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
import cpp
1414
import codingstandards.c.cert
15-
import codingstandards.cpp.dataflow.DataFlow
15+
import semmle.code.cpp.dataflow.DataFlow
1616

1717
class FgetposCall extends FunctionCall {
1818
FgetposCall() { this.getTarget().hasGlobalOrStdName("fgetpos") }

Diff for: c/cert/src/rules/FIO45-C/ToctouRaceConditionsWhileAccessingFiles.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import cpp
1515
import codingstandards.c.cert
1616
import codingstandards.cpp.standardlibrary.FileAccess
17-
import codingstandards.cpp.dataflow.DataFlow
17+
import semmle.code.cpp.dataflow.DataFlow
1818
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
1919

2020
/**

Diff for: c/cert/src/rules/MEM35-C/InsufficientMemoryAllocatedForObject.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import cpp
1616
import codingstandards.c.cert
1717
import codingstandards.cpp.Overflow
1818
import semmle.code.cpp.controlflow.Guards
19-
import codingstandards.cpp.dataflow.TaintTracking
19+
import semmle.code.cpp.dataflow.TaintTracking
2020
import semmle.code.cpp.models.Models
2121

2222
/**

Diff for: c/cert/src/rules/MEM36-C/DoNotModifyAlignmentOfMemoryWithRealloc.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import cpp
1616
import codingstandards.c.cert
1717
import codingstandards.cpp.Alignment
18-
import codingstandards.cpp.dataflow.DataFlow
18+
import semmle.code.cpp.dataflow.DataFlow
1919
import AlignedAllocToReallocFlow::PathGraph
2020

2121
int getStatedValue(Expr e) {

Diff for: c/cert/src/rules/MSC33-C/DoNotPassInvalidDataToTheAsctimeFunction.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
import cpp
1616
import codingstandards.c.cert
17-
import codingstandards.cpp.dataflow.DataFlow
17+
import semmle.code.cpp.dataflow.DataFlow
1818

1919
/**
2020
* The argument of a call to `asctime`

Diff for: c/cert/src/rules/MSC39-C/DoNotCallVaArgOnAVaListThatHasAnIndeterminateValue.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import cpp
1414
import codingstandards.c.cert
1515
import codingstandards.cpp.Macro
16-
import codingstandards.cpp.dataflow.DataFlow
16+
import semmle.code.cpp.dataflow.DataFlow
1717

1818
abstract class VaAccess extends Expr { }
1919

Diff for: c/cert/src/rules/SIG30-C/CallOnlyAsyncSafeFunctionsWithinSignalHandlers.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import cpp
1515
import codingstandards.c.cert
1616
import codingstandards.c.Signal
17-
import codingstandards.cpp.dataflow.DataFlow
17+
import semmle.code.cpp.dataflow.DataFlow
1818

1919
/**
2020
* Does not access an external variable except

Diff for: c/cert/src/rules/SIG35-C/DoNotReturnFromAComputationalExceptionHandler.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import cpp
1515
import codingstandards.c.cert
1616
import codingstandards.c.Signal
17-
import codingstandards.cpp.dataflow.DataFlow
17+
import semmle.code.cpp.dataflow.DataFlow
1818

1919
/**
2020
* CFG nodes preceeding a `ReturnStmt`

Diff for: c/cert/src/rules/STR30-C/DoNotAttemptToModifyStringLiterals.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import cpp
1515
import codingstandards.c.cert
1616
import semmle.code.cpp.security.BufferWrite
17-
import codingstandards.cpp.dataflow.DataFlow
17+
import semmle.code.cpp.dataflow.DataFlow
1818

1919
/**
2020
* Class that includes into `BufferWrite` functions that will modify their

Diff for: c/cert/src/rules/STR31-C/StringsHasSufficientSpaceForTheNullTerminator.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
import cpp
1717
import codingstandards.c.cert
18-
import codingstandards.cpp.dataflow.TaintTracking
18+
import semmle.code.cpp.dataflow.TaintTracking
1919
import codingstandards.cpp.PossiblyUnsafeStringOperation
2020

2121
/**

Diff for: c/cert/src/rules/STR32-C/NonNullTerminatedToFunctionThatExpectsAString.ql

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import cpp
1616
import codingstandards.c.cert
1717
import codingstandards.cpp.Naming
18-
import codingstandards.cpp.dataflow.TaintTracking
18+
import semmle.code.cpp.dataflow.TaintTracking
1919
import codingstandards.cpp.PossiblyUnsafeStringOperation
2020
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
2121

Diff for: c/cert/test/codeql-pack.lock.yml

+13-7
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,23 @@
22
lockVersion: 1.0.0
33
dependencies:
44
codeql/cpp-all:
5-
version: 0.12.9
5+
version: 1.4.2
66
codeql/dataflow:
7-
version: 0.2.3
7+
version: 1.1.1
8+
codeql/mad:
9+
version: 1.0.7
810
codeql/rangeanalysis:
9-
version: 0.0.11
11+
version: 1.0.7
1012
codeql/ssa:
11-
version: 0.2.12
13+
version: 1.0.7
1214
codeql/tutorial:
13-
version: 0.2.12
15+
version: 1.0.7
16+
codeql/typeflow:
17+
version: 1.0.7
1418
codeql/typetracking:
15-
version: 0.2.12
19+
version: 1.0.7
1620
codeql/util:
17-
version: 0.2.12
21+
version: 1.0.7
22+
codeql/xml:
23+
version: 1.0.7
1824
compiled: false

Diff for: c/cert/test/rules/ARR32-C/VariableLengthArraySizeNotInValidRange.expected

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (VariableLengthArraySizeNotInValidRange.ql:104,11-19)
2+
WARNING: module 'TaintTracking' has been deprecated and may be removed in future (VariableLengthArraySizeNotInValidRange.ql:87,5-18)
13
| test.c:14:8:14:8 | VLA declaration | Variable-length array dimension size may be in an invalid range. |
24
| test.c:15:8:15:8 | VLA declaration | Variable-length array dimension size may be in an invalid range. |
35
| test.c:16:8:16:8 | VLA declaration | Variable-length array dimension size may be in an invalid range. |

Diff for: c/cert/test/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.expected

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:23,60-68)
2+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:24,22-30)
3+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:36,20-28)
4+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:44,26-34)
5+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:65,3-11)
16
edges
27
| test.c:14:38:14:39 | p1 | test.c:18:10:18:11 | v1 | provenance | |
38
| test.c:14:38:14:39 | p1 | test.c:19:10:19:11 | v2 | provenance | |

Diff for: c/cert/test/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.expected

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotAddOrSubtractAScaledIntegerToAPointer.ql:72,56-64)
2+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotAddOrSubtractAScaledIntegerToAPointer.ql:73,22-30)
3+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotAddOrSubtractAScaledIntegerToAPointer.ql:75,20-28)
4+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotAddOrSubtractAScaledIntegerToAPointer.ql:84,45-53)
15
edges
26
| test.c:7:13:7:14 | p1 | test.c:9:9:9:10 | p1 | provenance | |
37
| test.c:16:19:16:41 | ... - ... | test.c:18:26:18:31 | offset | provenance | |

Diff for: c/cert/test/rules/CON30-C/CleanUpThreadSpecificStorage.expected

+6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CleanUpThreadSpecificStorage.ql:21,46-54)
2+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CleanUpThreadSpecificStorage.ql:22,22-30)
3+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CleanUpThreadSpecificStorage.ql:31,20-28)
4+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CleanUpThreadSpecificStorage.ql:41,35-43)
5+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CleanUpThreadSpecificStorage.ql:49,36-44)
6+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CleanUpThreadSpecificStorage.ql:51,36-44)
17
| test.c:27:3:27:12 | call to tss_create | Resources used by thread specific storage may not be cleaned up. |
28
| test.c:49:3:49:12 | call to tss_create | Resources used by thread specific storage may not be cleaned up. |
39
| test.c:71:3:71:12 | call to tss_create | Resources used by thread specific storage may not be cleaned up. |

Diff for: c/cert/test/rules/CON34-C/AppropriateThreadObjectStorageDurations.expected

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateThreadObjectStorageDurations.ql:28,29-37)
2+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateThreadObjectStorageDurations.ql:28,54-62)
3+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateThreadObjectStorageDurations.ql:35,62-70)
4+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateThreadObjectStorageDurations.ql:40,5-13)
5+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateThreadObjectStorageDurations.ql:40,30-38)
6+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateThreadObjectStorageDurations.ql:41,5-13)
7+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateThreadObjectStorageDurations.ql:41,30-38)
8+
WARNING: module 'TaintTracking' has been deprecated and may be removed in future (AppropriateThreadObjectStorageDurations.ql:28,3-16)
19
| test.c:23:3:23:13 | call to thrd_create | $@ not declared with appropriate storage duration | test.c:23:24:23:29 | & ... | Shared object |
210
| test.c:74:3:74:13 | call to thrd_create | $@ not declared with appropriate storage duration | test.c:74:24:74:24 | p | Shared object |
311
| test.c:85:3:85:13 | call to thrd_create | $@ not declared with appropriate storage duration | test.c:85:24:85:24 | p | Shared object |
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (ThreadObjectStorageDurationsNotInitialized.ql:28,38-46)
2+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (ThreadObjectStorageDurationsNotInitialized.ql:31,5-13)
3+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (ThreadObjectStorageDurationsNotInitialized.ql:31,30-38)
4+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (ThreadObjectStorageDurationsNotInitialized.ql:32,5-13)
5+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (ThreadObjectStorageDurationsNotInitialized.ql:32,30-38)
16
| test.c:14:7:14:13 | call to tss_get | Call to a thread specific storage function from within a threaded context on an object that may not be owned by this thread. |
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,7 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:22,20-28)
2+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:26,31-39)
3+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:39,6-14)
4+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:39,26-34)
5+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:45,3-11)
16
| test.c:3:10:3:10 | a | $@ with automatic storage may be accessible outside of its lifetime. | test.c:3:10:3:10 | a | a |
27
| test.c:15:4:15:8 | param [inner post update] | $@ with automatic storage may be accessible outside of its lifetime. | test.c:15:12:15:13 | a2 | a2 |
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (ErrnoReadBeforeReturn.ql:40,7-15)
12
| test.c:69:7:69:11 | * ... | Do not read `errno` before checking the return value of function $@. | test.c:68:3:68:7 | call to ftell | call to ftell |
23
| test.c:69:7:69:11 | call to __errno_location | Do not read `errno` before checking the return value of function $@. | test.c:68:3:68:7 | call to ftell | call to ftell |
34
| test.c:70:5:70:10 | call to perror | Do not read `errno` before checking the return value of function $@. | test.c:68:3:68:7 | call to ftell | call to ftell |
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (SetlocaleMightSetErrno.ql:64,7-15)
12
| test.c:98:3:98:11 | call to setlocale | Do not read `errno` before checking the return value of a call to `setlocale`. |
23
| test.c:104:7:104:15 | call to setlocale | The value of `errno` may be different than `0` when `setlocale` is called. The following `errno` check might be invalid. |

Diff for: c/cert/test/rules/ERR32-C/DoNotRelyOnIndeterminateValuesOfErrno.expected

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotRelyOnIndeterminateValuesOfErrno.ql:50,7-15)
2+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotRelyOnIndeterminateValuesOfErrno.ql:50,27-35)
3+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotRelyOnIndeterminateValuesOfErrno.ql:51,9-17)
4+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotRelyOnIndeterminateValuesOfErrno.ql:54,9-17)
15
| test.c:12:5:12:10 | call to perror | `errno` has indeterminate value after this $@. | test.c:10:21:10:26 | call to signal | call to signal |
26
| test.c:30:5:30:10 | call to perror | `errno` has indeterminate value after this $@. | test.c:26:21:26:26 | call to signal | call to signal |
37
| test.c:49:5:49:10 | call to perror | `errno` has indeterminate value after this $@. | test.c:45:21:45:26 | call to signal | call to signal |

Diff for: c/cert/test/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.expected

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DetectAndHandleStandardLibraryErrors.ql:453,5-13)
12
| test.c:18:3:18:11 | call to setlocale | Missing error detection for the call to function `setlocale`. |
23
| test.c:24:23:24:31 | call to setlocale | Missing error detection for the call to function `setlocale`. |
34
| test.c:29:22:29:27 | call to calloc | Missing error detection for the call to function `calloc`. |

0 commit comments

Comments
 (0)