Merge pull request #860 from github/lcartey/iofstream-performance

knewbury01 · web-flow · commit 7317d110afe2 · 2025-03-05T11:04:57.000Z
`IOFStreamMissingPositioning`: Improve performance
diff --git a/change_notes/2025-02-17-iofstream-performance.md b/change_notes/2025-02-17-iofstream-performance.md
@@ -0,0 +1,2 @@
+ - `A27-0-3`, `FIO309-C`, `FIO50-CPP`, `RULE-30-0-2` - `InterleavedInputOutputWithoutFlush.ql`, `DoNotAlternatelyIOFromStreamWithoutPositioning.ql`, `InterleavedInputOutputWithoutPosition.ql`, `ReadsAndWritesOnStreamNotSeparatedByPositioning.ql`:
+   - Reduce evaluation time on complex codebases.
diff --git a/cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll b/cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll
@@ -57,17 +57,19 @@ predicate sameSource(FunctionCall a, FunctionCall b) {
   sameFileSource(a, b)
 }
 
+bindingset[a, b]
 predicate sameAccessDirection(ReadWriteCall a, ReadWriteCall b) {
   a.getAccessDirection() = b.getAccessDirection()
 }
 
+bindingset[a, b]
 predicate oppositeAccessDirection(ReadWriteCall a, ReadWriteCall b) {
   not sameAccessDirection(a, b)
 }
 
 /**
  * A write operation reaching a read and vice versa
- * without intervening filepositioning
+ * without intervening file positioning calls.
  */
 ControlFlowNode reachesInExOperator(ReadWriteCall op) {
   result = op

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+ - `A27-0-3`, `FIO309-C`, `FIO50-CPP`, `RULE-30-0-2` - `InterleavedInputOutputWithoutFlush.ql`, `DoNotAlternatelyIOFromStreamWithoutPositioning.ql`, `InterleavedInputOutputWithoutPosition.ql`, `ReadsAndWritesOnStreamNotSeparatedByPositioning.ql`:
	`2`	`+ - Reduce evaluation time on complex codebases.`
Original file line number	Diff line number	Diff line change
`@@ -57,17 +57,19 @@ predicate sameSource(FunctionCall a, FunctionCall b) {`
`57`	`57`	`sameFileSource(a, b)`
`58`	`58`	`}`
`59`	`59`
	`60`	`+bindingset[a, b]`
`60`	`61`	`predicate sameAccessDirection(ReadWriteCall a, ReadWriteCall b) {`
`61`	`62`	`a.getAccessDirection() = b.getAccessDirection()`
`62`	`63`	`}`
`63`	`64`
	`65`	`+bindingset[a, b]`
`64`	`66`	`predicate oppositeAccessDirection(ReadWriteCall a, ReadWriteCall b) {`
`65`	`67`	`not sameAccessDirection(a, b)`
`66`	`68`	`}`
`67`	`69`
`68`	`70`	`/**`
`69`	`71`	`* A write operation reaching a read and vice versa`
`70`		`- * without intervening filepositioning`
	`72`	`+ * without intervening file positioning calls.`
`71`	`73`	`*/`
`72`	`74`	`ControlFlowNode reachesInExOperator(ReadWriteCall op) {`
`73`	`75`	`result = op`