A3-1-5: change definition of trivial length

of trivial member function to 10LOC

Author: knewbury01

change_notes/2024-07-03-fix-fp-611-A3-1-5.md

@@ -0,0 +1,2 @@
+- `A3-1-5` - `NonTrivialNonTemplateFunctionDefinedInsideClassDefinition.ql`, `TrivialOrTemplateFunctionDefinedOutsideClassDefinition.ql`:
+  - Fixes #611. Relax definition of trivial length of trivial member function to 10 LOC.

cpp/autosar/test/rules/A3-1-5/NonTrivialNonTemplateFunctionDefinedInsideClassDefinition.expected

@@ -1,2 +1 @@
-| test.cpp:12:7:12:13 | trivial | Non-Trivial or non-template function trivial is defined in the class body of $@. | test.cpp:2:7:2:7 | A | A |
 | test.cpp:26:7:26:9 | gcd | Non-Trivial or non-template function gcd is defined in the class body of $@. | test.cpp:2:7:2:7 | A | A |

cpp/autosar/test/rules/A3-1-5/test.cpp

@@ -9,7 +9,7 @@ class A {
 
   int getABar() { return 9; }
 
-  int trivial() { // NON_COMPLIANT
+  int not_trivial() { // COMPLIANT - with threshold of 10 loc
     ;
     ;
     ;

cpp/common/src/codingstandards/cpp/Class.qll

@@ -149,7 +149,8 @@ class IntrospectedMemberFunction extends MemberFunction {
   }
 
   predicate hasTrivialLength() {
-    this.getBlock().getNumStmt() <= 3 and
+    this.getBlock().getLastStmt().getLocation().getStartLine() -
+      this.getBlock().getStmt(0).getLocation().getStartLine() <= 10 and
     not exists(this.getBlock().getStmt(_).getChildStmt())
   }