RULE-8-7: Only report external identifiers with definitions

Author: lcartey

c/misra/src/rules/RULE-8-7/ShouldNotBeDefinedWithExternalLinkage.ql

@@ -46,6 +46,8 @@ predicate isReferencedInTranslationUnit(
 from ExternalIdentifiers e, ExternalIdentifierReference a1, TranslationUnit t1
 where
   not isExcluded(e, Declarations6Package::shouldNotBeDefinedWithExternalLinkageQuery()) and
+  // Only report external identifiers where we see the definition
+  e.hasDefinition() and
   isReferencedInTranslationUnit(e, a1, t1) and
   // Not referenced in any other translation unit
   not exists(TranslationUnit t2 |

c/misra/test/rules/RULE-8-7/test.h

@@ -2,4 +2,5 @@ extern int i;     // COMPLIANT - accessed multiple translation units
 extern int i1;    // NON_COMPLIANT - accessed one translation unit
 extern void f1(); // COMPLIANT  - accessed multiple translation units
 extern void f2(); // NON_COMPLIANT - accessed one translation unit
-extern void f4(); // COMPLIANT - accessed across translation units
+extern void f4(); // COMPLIANT - accessed across translation units
+extern void f5(); // COMPLIANT - no definition

c/misra/test/rules/RULE-8-7/test1.c

@@ -3,4 +3,5 @@ void f() {
   i = 0;
   f1();
   f4();
+  f5();
 }