Skip to content

A0-4-4: More domain cases #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lcartey opened this issue Feb 22, 2023 · 2 comments · Fixed by #572
Closed

A0-4-4: More domain cases #193

lcartey opened this issue Feb 22, 2023 · 2 comments · Fixed by #572
Assignees
@knewbury01
Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Low

Comments

@lcartey
Copy link
Collaborator

lcartey commented Feb 22, 2023

Affected rules

  • A0-4-4

Description

There are a number of math function domain errors we didn't previously capture, because they result in unspecified or undefined behaviour:

  • abs on "the most negative number" is undefined behaviour.
  • The second parameter of fmod should not be zero.
  • l?lrint[fl]? and l?lround[fl]? where the rounded input value is outside the range of the return type.
  • frexp on NaN or infinity
@lcartey lcartey added Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address Impact-Low false positive/false negative An issue related to observed false positives or false negatives. labels Feb 22, 2023
@lcartey
Copy link
Collaborator Author

lcartey commented Jan 29, 2024

pole error on log of 0?

@lcartey
Copy link
Collaborator Author

lcartey commented Jan 29, 2024

In general we seem to be missing all the pole cases.

@knewbury01 knewbury01 self-assigned this Apr 14, 2024
@knewbury01 knewbury01 mentioned this issue Apr 23, 2024
Merged
30 tasks
@knewbury01 knewbury01 moved this from Triaged to Ready for review in Coding Standards Public Development Board Apr 23, 2024
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Coding Standards Public Development Board Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knewbury01 knewbury01

Labels
Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Low
Projects
Coding Standards Public Development Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UncheckedRangeDomainPoleErrors: add missing cases knewbury01/codeql-coding-standards
2 participants
@lcartey @knewbury01