v2.28.0 causes performance degradation in analysis.

[rak3-sh]

Describe the bug
After upgrading to codeql-coding-standards v2.28.0, the CodeQL analysis goes into an infinite loop for one of the projects in our organization. It is observed that queries using getPotentialScopeOfDeclarationStrict and getPotentialScopeOfDeclarationStrict_candidate functions in Scope.qll get stuck. One of these queries is the IdentifierHiding.ql.

To Reproduce
This problem was observed on a internal project. It is difficult to provide a minimized sample. However, in the PR that changes getPotentialScopeOfDeclarationStrict has a comment about a performance degrade. This is likely the problem.

Expected behavior
The query performs similar to v2.27.0.

Environment

• CodeQL Coding Standards version: v2.28.0
• CodeQL version: CodeQL CLI v2.14.6
• Operating System: Linux

Additional context
Add any other context about the problem here