Merge pull request #19812 from joefarebrother/python-qual-tagging

Python: Tag quality queries with `quality` and sub category.

Author: tausbn

python/ql/integration-tests/query-suite/python-code-quality-extended.qls.expected

@@ -1,8 +1,99 @@
+ql/python/ql/src/Classes/ConflictingAttributesInBaseClasses.ql
+ql/python/ql/src/Classes/DefineEqualsWhenAddingAttributes.ql
+ql/python/ql/src/Classes/EqualsOrHash.ql
+ql/python/ql/src/Classes/InconsistentMRO.ql
 ql/python/ql/src/Classes/InitCallsSubclass/InitCallsSubclassMethod.ql
+ql/python/ql/src/Classes/MissingCallToDel.ql
+ql/python/ql/src/Classes/MissingCallToInit.ql
+ql/python/ql/src/Classes/MutatingDescriptor.ql
+ql/python/ql/src/Classes/SubclassShadowing.ql
+ql/python/ql/src/Classes/SuperclassDelCalledMultipleTimes.ql
+ql/python/ql/src/Classes/SuperclassInitCalledMultipleTimes.ql
+ql/python/ql/src/Classes/WrongNameForArgumentInClassInstantiation.ql
+ql/python/ql/src/Classes/WrongNumberArgumentsInClassInstantiation.ql
+ql/python/ql/src/Exceptions/CatchingBaseException.ql
+ql/python/ql/src/Exceptions/EmptyExcept.ql
+ql/python/ql/src/Exceptions/IllegalExceptionHandlerType.ql
+ql/python/ql/src/Exceptions/IllegalRaise.ql
+ql/python/ql/src/Exceptions/IncorrectExceptOrder.ql
+ql/python/ql/src/Exceptions/NotImplementedIsNotAnException.ql
+ql/python/ql/src/Expressions/CallToSuperWrongClass.ql
+ql/python/ql/src/Expressions/CompareConstants.ql
+ql/python/ql/src/Expressions/CompareIdenticalValues.ql
+ql/python/ql/src/Expressions/CompareIdenticalValuesMissingSelf.ql
+ql/python/ql/src/Expressions/Comparisons/UselessComparisonTest.ql
+ql/python/ql/src/Expressions/ContainsNonContainer.ql
+ql/python/ql/src/Expressions/DuplicateKeyInDictionaryLiteral.ql
+ql/python/ql/src/Expressions/EqualsNone.ql
+ql/python/ql/src/Expressions/ExpectedMappingForFormatString.ql
+ql/python/ql/src/Expressions/ExplicitCallToDel.ql
+ql/python/ql/src/Expressions/Formatting/MixedExplicitImplicitIn3101Format.ql
+ql/python/ql/src/Expressions/Formatting/UnusedArgumentIn3101Format.ql
+ql/python/ql/src/Expressions/Formatting/UnusedNamedArgumentIn3101Format.ql
+ql/python/ql/src/Expressions/Formatting/WrongNameInArgumentsFor3101Format.ql
+ql/python/ql/src/Expressions/Formatting/WrongNumberArgumentsFor3101Format.ql
+ql/python/ql/src/Expressions/HashedButNoHash.ql
+ql/python/ql/src/Expressions/IncorrectComparisonUsingIs.ql
+ql/python/ql/src/Expressions/NonCallableCalled.ql
+ql/python/ql/src/Expressions/Regex/BackspaceEscape.ql
+ql/python/ql/src/Expressions/Regex/DuplicateCharacterInSet.ql
+ql/python/ql/src/Expressions/Regex/MissingPartSpecialGroup.ql
+ql/python/ql/src/Expressions/Regex/UnmatchableCaret.ql
+ql/python/ql/src/Expressions/Regex/UnmatchableDollar.ql
+ql/python/ql/src/Expressions/UnintentionalImplicitStringConcatenation.ql
+ql/python/ql/src/Expressions/UnnecessaryLambda.ql
+ql/python/ql/src/Expressions/UnsupportedFormatCharacter.ql
+ql/python/ql/src/Expressions/WrongNameForArgumentInCall.ql
+ql/python/ql/src/Expressions/WrongNumberArgumentsForFormat.ql
+ql/python/ql/src/Expressions/WrongNumberArgumentsInCall.ql
+ql/python/ql/src/Functions/ConsistentReturns.ql
+ql/python/ql/src/Functions/ExplicitReturnInInit.ql
+ql/python/ql/src/Functions/IncorrectRaiseInSpecialMethod.ql
+ql/python/ql/src/Functions/IncorrectlyOverriddenMethod.ql
+ql/python/ql/src/Functions/IncorrectlySpecifiedOverriddenMethod.ql
+ql/python/ql/src/Functions/InitIsGenerator.ql
+ql/python/ql/src/Functions/IterReturnsNonIterator.ql
 ql/python/ql/src/Functions/IterReturnsNonSelf.ql
+ql/python/ql/src/Functions/ModificationOfParameterWithDefault.ql
 ql/python/ql/src/Functions/NonCls.ql
 ql/python/ql/src/Functions/NonSelf.ql
+ql/python/ql/src/Functions/OverlyComplexDelMethod.ql
 ql/python/ql/src/Functions/ReturnConsistentTupleSizes.ql
+ql/python/ql/src/Functions/SignatureOverriddenMethod.ql
 ql/python/ql/src/Functions/SignatureSpecialMethods.ql
+ql/python/ql/src/Functions/UseImplicitNoneReturnValue.ql
+ql/python/ql/src/Imports/EncodingError.ql
+ql/python/ql/src/Imports/ImportandImportFrom.ql
+ql/python/ql/src/Imports/ModuleImportsItself.ql
+ql/python/ql/src/Imports/MultipleImports.ql
+ql/python/ql/src/Imports/SyntaxError.ql
+ql/python/ql/src/Imports/UnintentionalImport.ql
+ql/python/ql/src/Imports/UnusedImport.ql
+ql/python/ql/src/Lexical/CommentedOutCode.ql
 ql/python/ql/src/Resources/FileNotAlwaysClosed.ql
+ql/python/ql/src/Statements/AssertOnTuple.ql
+ql/python/ql/src/Statements/ConstantInConditional.ql
+ql/python/ql/src/Statements/IterableStringOrSequence.ql
+ql/python/ql/src/Statements/MismatchInMultipleAssignment.ql
+ql/python/ql/src/Statements/ModificationOfLocals.ql
+ql/python/ql/src/Statements/NestedLoopsSameVariable.ql
+ql/python/ql/src/Statements/NestedLoopsSameVariableWithReuse.ql
+ql/python/ql/src/Statements/NonIteratorInForLoop.ql
+ql/python/ql/src/Statements/RedundantAssignment.ql
+ql/python/ql/src/Statements/ShouldUseWithStatement.ql
+ql/python/ql/src/Statements/SideEffectInAssert.ql
+ql/python/ql/src/Statements/StatementNoEffect.ql
+ql/python/ql/src/Statements/TopLevelPrint.ql
+ql/python/ql/src/Statements/UnnecessaryElseClause.ql
+ql/python/ql/src/Statements/UnnecessaryPass.ql
+ql/python/ql/src/Statements/UnreachableCode.ql
+ql/python/ql/src/Statements/UnusedExceptionObject.ql
+ql/python/ql/src/Statements/UseOfExit.ql
+ql/python/ql/src/Testing/ImpreciseAssert.ql
+ql/python/ql/src/Variables/GlobalAtModuleLevel.ql
 ql/python/ql/src/Variables/LoopVariableCapture/LoopVariableCapture.ql
+ql/python/ql/src/Variables/MultiplyDefined.ql
+ql/python/ql/src/Variables/SuspiciousUnusedLoopIterationVariable.ql
+ql/python/ql/src/Variables/UndefinedExport.ql
+ql/python/ql/src/Variables/UnusedLocalVariable.ql
+ql/python/ql/src/Variables/UnusedModuleVariable.ql

python/ql/integration-tests/query-suite/python-code-quality.qls.expected

@@ -1,8 +1,99 @@
+ql/python/ql/src/Classes/ConflictingAttributesInBaseClasses.ql
+ql/python/ql/src/Classes/DefineEqualsWhenAddingAttributes.ql
+ql/python/ql/src/Classes/EqualsOrHash.ql
+ql/python/ql/src/Classes/InconsistentMRO.ql
 ql/python/ql/src/Classes/InitCallsSubclass/InitCallsSubclassMethod.ql
+ql/python/ql/src/Classes/MissingCallToDel.ql
+ql/python/ql/src/Classes/MissingCallToInit.ql
+ql/python/ql/src/Classes/MutatingDescriptor.ql
+ql/python/ql/src/Classes/SubclassShadowing.ql
+ql/python/ql/src/Classes/SuperclassDelCalledMultipleTimes.ql
+ql/python/ql/src/Classes/SuperclassInitCalledMultipleTimes.ql
+ql/python/ql/src/Classes/WrongNameForArgumentInClassInstantiation.ql
+ql/python/ql/src/Classes/WrongNumberArgumentsInClassInstantiation.ql
+ql/python/ql/src/Exceptions/CatchingBaseException.ql
+ql/python/ql/src/Exceptions/EmptyExcept.ql
+ql/python/ql/src/Exceptions/IllegalExceptionHandlerType.ql
+ql/python/ql/src/Exceptions/IllegalRaise.ql
+ql/python/ql/src/Exceptions/IncorrectExceptOrder.ql
+ql/python/ql/src/Exceptions/NotImplementedIsNotAnException.ql
+ql/python/ql/src/Expressions/CallToSuperWrongClass.ql
+ql/python/ql/src/Expressions/CompareConstants.ql
+ql/python/ql/src/Expressions/CompareIdenticalValues.ql
+ql/python/ql/src/Expressions/CompareIdenticalValuesMissingSelf.ql
+ql/python/ql/src/Expressions/Comparisons/UselessComparisonTest.ql
+ql/python/ql/src/Expressions/ContainsNonContainer.ql
+ql/python/ql/src/Expressions/DuplicateKeyInDictionaryLiteral.ql
+ql/python/ql/src/Expressions/EqualsNone.ql
+ql/python/ql/src/Expressions/ExpectedMappingForFormatString.ql
+ql/python/ql/src/Expressions/ExplicitCallToDel.ql
+ql/python/ql/src/Expressions/Formatting/MixedExplicitImplicitIn3101Format.ql
+ql/python/ql/src/Expressions/Formatting/UnusedArgumentIn3101Format.ql
+ql/python/ql/src/Expressions/Formatting/UnusedNamedArgumentIn3101Format.ql
+ql/python/ql/src/Expressions/Formatting/WrongNameInArgumentsFor3101Format.ql
+ql/python/ql/src/Expressions/Formatting/WrongNumberArgumentsFor3101Format.ql
+ql/python/ql/src/Expressions/HashedButNoHash.ql
+ql/python/ql/src/Expressions/IncorrectComparisonUsingIs.ql
+ql/python/ql/src/Expressions/NonCallableCalled.ql
+ql/python/ql/src/Expressions/Regex/BackspaceEscape.ql
+ql/python/ql/src/Expressions/Regex/DuplicateCharacterInSet.ql
+ql/python/ql/src/Expressions/Regex/MissingPartSpecialGroup.ql
+ql/python/ql/src/Expressions/Regex/UnmatchableCaret.ql
+ql/python/ql/src/Expressions/Regex/UnmatchableDollar.ql
+ql/python/ql/src/Expressions/UnintentionalImplicitStringConcatenation.ql
+ql/python/ql/src/Expressions/UnnecessaryLambda.ql
+ql/python/ql/src/Expressions/UnsupportedFormatCharacter.ql
+ql/python/ql/src/Expressions/WrongNameForArgumentInCall.ql
+ql/python/ql/src/Expressions/WrongNumberArgumentsForFormat.ql
+ql/python/ql/src/Expressions/WrongNumberArgumentsInCall.ql
+ql/python/ql/src/Functions/ConsistentReturns.ql
+ql/python/ql/src/Functions/ExplicitReturnInInit.ql
+ql/python/ql/src/Functions/IncorrectRaiseInSpecialMethod.ql
+ql/python/ql/src/Functions/IncorrectlyOverriddenMethod.ql
+ql/python/ql/src/Functions/IncorrectlySpecifiedOverriddenMethod.ql
+ql/python/ql/src/Functions/InitIsGenerator.ql
+ql/python/ql/src/Functions/IterReturnsNonIterator.ql
 ql/python/ql/src/Functions/IterReturnsNonSelf.ql
+ql/python/ql/src/Functions/ModificationOfParameterWithDefault.ql
 ql/python/ql/src/Functions/NonCls.ql
 ql/python/ql/src/Functions/NonSelf.ql
+ql/python/ql/src/Functions/OverlyComplexDelMethod.ql
 ql/python/ql/src/Functions/ReturnConsistentTupleSizes.ql
+ql/python/ql/src/Functions/SignatureOverriddenMethod.ql
 ql/python/ql/src/Functions/SignatureSpecialMethods.ql
+ql/python/ql/src/Functions/UseImplicitNoneReturnValue.ql
+ql/python/ql/src/Imports/EncodingError.ql
+ql/python/ql/src/Imports/ImportandImportFrom.ql
+ql/python/ql/src/Imports/ModuleImportsItself.ql
+ql/python/ql/src/Imports/MultipleImports.ql
+ql/python/ql/src/Imports/SyntaxError.ql
+ql/python/ql/src/Imports/UnintentionalImport.ql
+ql/python/ql/src/Imports/UnusedImport.ql
+ql/python/ql/src/Lexical/CommentedOutCode.ql
 ql/python/ql/src/Resources/FileNotAlwaysClosed.ql
+ql/python/ql/src/Statements/AssertOnTuple.ql
+ql/python/ql/src/Statements/ConstantInConditional.ql
+ql/python/ql/src/Statements/IterableStringOrSequence.ql
+ql/python/ql/src/Statements/MismatchInMultipleAssignment.ql
+ql/python/ql/src/Statements/ModificationOfLocals.ql
+ql/python/ql/src/Statements/NestedLoopsSameVariable.ql
+ql/python/ql/src/Statements/NestedLoopsSameVariableWithReuse.ql
+ql/python/ql/src/Statements/NonIteratorInForLoop.ql
+ql/python/ql/src/Statements/RedundantAssignment.ql
+ql/python/ql/src/Statements/ShouldUseWithStatement.ql
+ql/python/ql/src/Statements/SideEffectInAssert.ql
+ql/python/ql/src/Statements/StatementNoEffect.ql
+ql/python/ql/src/Statements/TopLevelPrint.ql
+ql/python/ql/src/Statements/UnnecessaryElseClause.ql
+ql/python/ql/src/Statements/UnnecessaryPass.ql
+ql/python/ql/src/Statements/UnreachableCode.ql
+ql/python/ql/src/Statements/UnusedExceptionObject.ql
+ql/python/ql/src/Statements/UseOfExit.ql
+ql/python/ql/src/Testing/ImpreciseAssert.ql
+ql/python/ql/src/Variables/GlobalAtModuleLevel.ql
 ql/python/ql/src/Variables/LoopVariableCapture/LoopVariableCapture.ql
+ql/python/ql/src/Variables/MultiplyDefined.ql
+ql/python/ql/src/Variables/SuspiciousUnusedLoopIterationVariable.ql
+ql/python/ql/src/Variables/UndefinedExport.ql
+ql/python/ql/src/Variables/UnusedLocalVariable.ql
+ql/python/ql/src/Variables/UnusedModuleVariable.ql

python/ql/src/Classes/ConflictingAttributesInBaseClasses.ql

@@ -2,9 +2,9 @@
  * @name Conflicting attributes in base classes
  * @description When a class subclasses multiple base classes and more than one base class defines the same attribute, attribute overriding may result in unexpected behavior by instances of this class.
  * @kind problem
- * @tags reliability
- *       maintainability
- *       modularity
+ * @tags quality
+ *       reliability
+ *       correctness
  * @problem.severity warning
  * @sub-severity low
  * @precision high

python/ql/src/Classes/DefineEqualsWhenAddingAttributes.ql

@@ -2,7 +2,8 @@
  * @name `__eq__` not overridden when adding attributes
  * @description When adding new attributes to instances of a class, equality for that class needs to be defined.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity warning
  * @sub-severity high

python/ql/src/Classes/EqualsOrHash.ql

@@ -2,7 +2,8 @@
  * @name Inconsistent equality and hashing
  * @description Defining equality for a class without also defining hashability (or vice-versa) violates the object model.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-581
  * @problem.severity warning

python/ql/src/Classes/InconsistentMRO.ql

@@ -2,7 +2,8 @@
  * @name Inconsistent method resolution order
  * @description Class definition will raise a type error at runtime due to inconsistent method resolution order(MRO)
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity error
  * @sub-severity high

python/ql/src/Classes/MissingCallToDel.ql

@@ -2,8 +2,10 @@
  * @name Missing call to `__del__` during object destruction
  * @description An omitted call to a super-class `__del__` method may lead to class instances not being cleaned up properly.
  * @kind problem
- * @tags efficiency
+ * @tags quality
+ *       reliability
  *       correctness
+ *       performance
  * @problem.severity error
  * @sub-severity low
  * @precision high

python/ql/src/Classes/MissingCallToInit.ql

@@ -2,7 +2,8 @@
  * @name Missing call to `__init__` during object initialization
  * @description An omitted call to a super-class `__init__` method may lead to objects of this class not being fully initialized.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity error
  * @sub-severity low

python/ql/src/Classes/MutatingDescriptor.ql

@@ -2,7 +2,8 @@
  * @name Mutation of descriptor in `__get__` or `__set__` method.
  * @description Descriptor objects can be shared across many instances. Mutating them can cause strange side effects or race conditions.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity error
  * @sub-severity low

python/ql/src/Classes/SubclassShadowing.ql

@@ -4,7 +4,8 @@
  *              method, hides the method in the subclass.
  * @kind problem
  * @problem.severity error
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  * @sub-severity low
  * @precision high