Rust: Add tests for flow through clone

Author: paldepind

rust/ql/test/library-tests/dataflow/modeled/inline-flow.expected

@@ -0,0 +1,48 @@
+models
+| 1 | Summary: lang:core; <crate::option::Option>::unwrap; Argument[self].Variant[crate::option::Option::Some(0)]; ReturnValue; value |
+| 2 | Summary: lang:core; <crate::result::Result>::unwrap; Argument[self].Variant[crate::result::Result::Ok(0)]; ReturnValue; value |
+edges
+| main.rs:13:9:13:9 | a [Some] | main.rs:14:10:14:10 | a [Some] | provenance |  |
+| main.rs:13:13:13:28 | Some(...) [Some] | main.rs:13:9:13:9 | a [Some] | provenance |  |
+| main.rs:13:18:13:27 | source(...) | main.rs:13:13:13:28 | Some(...) [Some] | provenance |  |
+| main.rs:14:10:14:10 | a [Some] | main.rs:14:10:14:19 | a.unwrap(...) | provenance | MaD:1 |
+| main.rs:20:9:20:9 | a [Ok] | main.rs:21:10:21:10 | a [Ok] | provenance |  |
+| main.rs:20:31:20:44 | Ok(...) [Ok] | main.rs:20:9:20:9 | a [Ok] | provenance |  |
+| main.rs:20:34:20:43 | source(...) | main.rs:20:31:20:44 | Ok(...) [Ok] | provenance |  |
+| main.rs:21:10:21:10 | a [Ok] | main.rs:21:10:21:19 | a.unwrap(...) | provenance | MaD:2 |
+| main.rs:27:9:27:9 | a | main.rs:28:10:28:10 | a | provenance |  |
+| main.rs:27:13:27:22 | source(...) | main.rs:27:9:27:9 | a | provenance |  |
+| main.rs:42:13:42:13 | w [Wrapper.n] | main.rs:43:15:43:15 | w [Wrapper.n] | provenance |  |
+| main.rs:42:17:42:41 | Wrapper {...} [Wrapper.n] | main.rs:42:13:42:13 | w [Wrapper.n] | provenance |  |
+| main.rs:42:30:42:39 | source(...) | main.rs:42:17:42:41 | Wrapper {...} [Wrapper.n] | provenance |  |
+| main.rs:43:15:43:15 | w [Wrapper.n] | main.rs:44:13:44:28 | Wrapper {...} [Wrapper.n] | provenance |  |
+| main.rs:44:13:44:28 | Wrapper {...} [Wrapper.n] | main.rs:44:26:44:26 | n | provenance |  |
+| main.rs:44:26:44:26 | n | main.rs:44:38:44:38 | n | provenance |  |
+nodes
+| main.rs:13:9:13:9 | a [Some] | semmle.label | a [Some] |
+| main.rs:13:13:13:28 | Some(...) [Some] | semmle.label | Some(...) [Some] |
+| main.rs:13:18:13:27 | source(...) | semmle.label | source(...) |
+| main.rs:14:10:14:10 | a [Some] | semmle.label | a [Some] |
+| main.rs:14:10:14:19 | a.unwrap(...) | semmle.label | a.unwrap(...) |
+| main.rs:20:9:20:9 | a [Ok] | semmle.label | a [Ok] |
+| main.rs:20:31:20:44 | Ok(...) [Ok] | semmle.label | Ok(...) [Ok] |
+| main.rs:20:34:20:43 | source(...) | semmle.label | source(...) |
+| main.rs:21:10:21:10 | a [Ok] | semmle.label | a [Ok] |
+| main.rs:21:10:21:19 | a.unwrap(...) | semmle.label | a.unwrap(...) |
+| main.rs:27:9:27:9 | a | semmle.label | a |
+| main.rs:27:13:27:22 | source(...) | semmle.label | source(...) |
+| main.rs:28:10:28:10 | a | semmle.label | a |
+| main.rs:42:13:42:13 | w [Wrapper.n] | semmle.label | w [Wrapper.n] |
+| main.rs:42:17:42:41 | Wrapper {...} [Wrapper.n] | semmle.label | Wrapper {...} [Wrapper.n] |
+| main.rs:42:30:42:39 | source(...) | semmle.label | source(...) |
+| main.rs:43:15:43:15 | w [Wrapper.n] | semmle.label | w [Wrapper.n] |
+| main.rs:44:13:44:28 | Wrapper {...} [Wrapper.n] | semmle.label | Wrapper {...} [Wrapper.n] |
+| main.rs:44:26:44:26 | n | semmle.label | n |
+| main.rs:44:38:44:38 | n | semmle.label | n |
+subpaths
+testFailures
+#select
+| main.rs:14:10:14:19 | a.unwrap(...) | main.rs:13:18:13:27 | source(...) | main.rs:14:10:14:19 | a.unwrap(...) | $@ | main.rs:13:18:13:27 | source(...) | source(...) |
+| main.rs:21:10:21:19 | a.unwrap(...) | main.rs:20:34:20:43 | source(...) | main.rs:21:10:21:19 | a.unwrap(...) | $@ | main.rs:20:34:20:43 | source(...) | source(...) |
+| main.rs:28:10:28:10 | a | main.rs:27:13:27:22 | source(...) | main.rs:28:10:28:10 | a | $@ | main.rs:27:13:27:22 | source(...) | source(...) |
+| main.rs:44:38:44:38 | n | main.rs:42:30:42:39 | source(...) | main.rs:44:38:44:38 | n | $@ | main.rs:42:30:42:39 | source(...) | source(...) |

rust/ql/test/library-tests/dataflow/modeled/inline-flow.ql

@@ -0,0 +1,12 @@
+/**
+ * @kind path-problem
+ */
+
+import rust
+import utils.test.InlineFlowTest
+import DefaultFlowTest
+import ValueFlow::PathGraph
+
+from ValueFlow::PathNode source, ValueFlow::PathNode sink
+where ValueFlow::flowPath(source, sink)
+select sink, source, sink, "$@", source, source.toString()

rust/ql/test/library-tests/dataflow/modeled/main.rs

@@ -0,0 +1,58 @@
+
+fn source(i: i64) -> i64 {
+    1000 + i
+}
+
+fn sink(s: i64) {
+    println!("{}", s);
+}
+
+// Flow through `clone` methods
+
+fn option_clone() {
+    let a = Some(source(88));
+    sink(a.unwrap()); // $ hasValueFlow=88
+    let b = a.clone();
+    sink(b.unwrap()); // $ MISSING: hasValueFlow=88
+}
+
+fn result_clone() {
+    let a: Result<i64, i64> = Ok(source(37));
+    sink(a.unwrap()); // $ hasValueFlow=37
+    let b = a.clone();
+    sink(b.unwrap()); // $ MISSING: hasValueFlow=37
+}
+
+fn i64_clone() {
+    let a = source(12);
+    sink(a); // $ hasValueFlow=12
+    let b = a.clone();
+    sink(b); // $ MISSING: hasValueFlow=12
+}
+
+mod my_clone {
+    use super::{source, sink};
+
+    #[derive(Clone)]
+    struct Wrapper {
+        n: i64
+    }
+
+    pub fn wrapper_clone() {
+        let w = Wrapper { n: source(73) };
+        match w {
+            Wrapper { n: n } => sink(n) // $ hasValueFlow=73
+        }
+        let u = w.clone();
+        match u {
+            Wrapper { n: n } => sink(n) // $ MISSING: hasValueFlow=73
+        }
+    }
+}
+
+fn main() {
+    option_clone();
+    result_clone();
+    i64_clone();
+    my_clone::wrapper_clone();
+}