Skip to content

Commit 0ab510f

Browse files
committed
add test that requires flowToExpr
1 parent 3d6a526 commit 0ab510f

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
| tst.js:8:22:8:39 | req.query.password | $@ for GET requests uses query parameter as sensitive data. | tst.js:6:19:14:1 | (req, r ... serId\\n} | Route handler |
2+
| tst.js:26:22:26:42 | req.par ... sword') | $@ for GET requests uses query parameter as sensitive data. | tst.js:24:20:35:1 | (req, r ... });\\n} | Route handler |
3+
| tst.js:31:24:31:40 | req.param('word') | $@ for GET requests uses query parameter as sensitive data. | tst.js:24:20:35:1 | (req, r ... });\\n} | Route handler |

javascript/ql/test/query-tests/Security/CWE-598/tst.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,17 @@ app.post("/login", (req, res) => {
1919
checkUser(username, password, (result) => {
2020
res.send(result);
2121
});
22+
});
23+
24+
app.get("/login2", (req, res) => {
25+
const username = req.param('username'); // NOT OK - usernames are fine
26+
const password = req.param('password'); // NOT OK - password read
27+
checkUser(username, password, (result) => {
28+
res.send(result);
29+
});
30+
31+
const myPassword = req.param('word'); // NOT OK - is used in a sensitive write below.
32+
checkUser(username, myPassword, (result) => {
33+
res.send(result);
34+
});
2235
});

0 commit comments

Comments
 (0)