Skip to content

Commit 2f2c9f8

Browse files
authored
Merge pull request #18895 from geoffw0/docimplicit
Data flow: Improve doc for defaultImplicitTaintRead.
2 parents 4f810df + 1b35c0b commit 2f2c9f8

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

shared/dataflow/codeql/dataflow/TaintTracking.qll

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,11 @@ signature module InputSig<LocationSig Location, DF::InputSig<Location> Lang> {
2626

2727
/**
2828
* Holds if taint flow configurations should allow implicit reads of `c` at sinks
29-
* and inputs to additional taint steps.
29+
* and inputs to additional taint steps defined in the flow `Config`.
30+
*
31+
* Note that this (deliberately) does not include at additional taint steps defined
32+
* globally in `defaultAdditionalTaintStep`. These models are expected to be precise
33+
* and therefore to not require implicit reads.
3034
*/
3135
bindingset[node]
3236
predicate defaultImplicitTaintRead(Lang::Node node, Lang::ContentSet c);

0 commit comments

Comments
 (0)