Skip to content

Commit 491f72b

Browse files
committed
Python: Adjust generated code to be more familiar
1 parent de69e4c commit 491f72b

File tree

1 file changed

+42
-21
lines changed

1 file changed

+42
-21
lines changed

python/ql/lib/semmle/python/frameworks/RestFramework.qll

Lines changed: 42 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,53 +37,74 @@ private module RestFramework {
3737
*/
3838
private class ModeledApiViewClasses extends Django::Views::View::ModeledSubclass {
3939
ModeledApiViewClasses() {
40-
this = API::moduleImport("rest_framework").getMember("views").getMember("APIView") or
40+
this = API::moduleImport("rest_framework").getMember("views").getMember("APIView")
41+
or
4142
// imports generated by python/frameworks/internal/SubclassFinder.qll
4243
this =
4344
API::moduleImport("rest_framework")
4445
.getMember("authtoken")
4546
.getMember("views")
46-
.getMember("APIView") or
47+
.getMember("APIView")
48+
or
4749
this =
4850
API::moduleImport("rest_framework")
4951
.getMember("authtoken")
5052
.getMember("views")
51-
.getMember("ObtainAuthToken") or
52-
this = API::moduleImport("rest_framework").getMember("decorators").getMember("APIView") or
53-
this = API::moduleImport("rest_framework").getMember("generics").getMember("CreateAPIView") or
54-
this = API::moduleImport("rest_framework").getMember("generics").getMember("DestroyAPIView") or
55-
this = API::moduleImport("rest_framework").getMember("generics").getMember("GenericAPIView") or
56-
this = API::moduleImport("rest_framework").getMember("generics").getMember("ListAPIView") or
53+
.getMember("ObtainAuthToken")
54+
or
55+
this = API::moduleImport("rest_framework").getMember("decorators").getMember("APIView")
56+
or
57+
this = API::moduleImport("rest_framework").getMember("generics").getMember("CreateAPIView")
58+
or
59+
this = API::moduleImport("rest_framework").getMember("generics").getMember("DestroyAPIView")
60+
or
61+
this = API::moduleImport("rest_framework").getMember("generics").getMember("GenericAPIView")
62+
or
63+
this = API::moduleImport("rest_framework").getMember("generics").getMember("ListAPIView")
64+
or
5765
this =
58-
API::moduleImport("rest_framework").getMember("generics").getMember("ListCreateAPIView") or
59-
this = API::moduleImport("rest_framework").getMember("generics").getMember("RetrieveAPIView") or
66+
API::moduleImport("rest_framework").getMember("generics").getMember("ListCreateAPIView")
67+
or
68+
this = API::moduleImport("rest_framework").getMember("generics").getMember("RetrieveAPIView")
69+
or
6070
this =
6171
API::moduleImport("rest_framework")
6272
.getMember("generics")
63-
.getMember("RetrieveDestroyAPIView") or
73+
.getMember("RetrieveDestroyAPIView")
74+
or
6475
this =
65-
API::moduleImport("rest_framework").getMember("generics").getMember("RetrieveUpdateAPIView") or
76+
API::moduleImport("rest_framework").getMember("generics").getMember("RetrieveUpdateAPIView")
77+
or
6678
this =
6779
API::moduleImport("rest_framework")
6880
.getMember("generics")
69-
.getMember("RetrieveUpdateDestroyAPIView") or
70-
this = API::moduleImport("rest_framework").getMember("generics").getMember("UpdateAPIView") or
71-
this = API::moduleImport("rest_framework").getMember("routers").getMember("APIRootView") or
72-
this = API::moduleImport("rest_framework").getMember("routers").getMember("SchemaView") or
81+
.getMember("RetrieveUpdateDestroyAPIView")
82+
or
83+
this = API::moduleImport("rest_framework").getMember("generics").getMember("UpdateAPIView")
84+
or
85+
this = API::moduleImport("rest_framework").getMember("routers").getMember("APIRootView")
86+
or
87+
this = API::moduleImport("rest_framework").getMember("routers").getMember("SchemaView")
88+
or
7389
this =
7490
API::moduleImport("rest_framework")
7591
.getMember("schemas")
7692
.getMember("views")
77-
.getMember("APIView") or
93+
.getMember("APIView")
94+
or
7895
this =
7996
API::moduleImport("rest_framework")
8097
.getMember("schemas")
8198
.getMember("views")
82-
.getMember("SchemaView") or
83-
this = API::moduleImport("rest_framework").getMember("viewsets").getMember("GenericViewSet") or
84-
this = API::moduleImport("rest_framework").getMember("viewsets").getMember("ModelViewSet") or
99+
.getMember("SchemaView")
100+
or
101+
this = API::moduleImport("rest_framework").getMember("viewsets").getMember("GenericViewSet")
102+
or
103+
this = API::moduleImport("rest_framework").getMember("viewsets").getMember("ModelViewSet")
104+
or
85105
this =
86-
API::moduleImport("rest_framework").getMember("viewsets").getMember("ReadOnlyModelViewSet") or
106+
API::moduleImport("rest_framework").getMember("viewsets").getMember("ReadOnlyModelViewSet")
107+
or
87108
this = API::moduleImport("rest_framework").getMember("viewsets").getMember("ViewSet")
88109
}
89110
}

0 commit comments

Comments
 (0)