Use location of basic block for SsaImplicitDefinition

owen-mc · owen-mc · commit 6dad937ce258 · 2025-02-26T12:29:52.000Z
diff --git a/go/ql/lib/semmle/go/dataflow/SSA.qll b/go/ql/lib/semmle/go/dataflow/SSA.qll
@@ -217,9 +217,7 @@ abstract class SsaImplicitDefinition extends SsaDefinition {
   override predicate hasLocationInfo(
     string filepath, int startline, int startcolumn, int endline, int endcolumn
   ) {
-    endline = startline and
-    endcolumn = startcolumn and
-    this.getBasicBlock().hasLocationInfo(filepath, startline, startcolumn, _, _)
+    this.getBasicBlock().hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -217,9 +217,7 @@ abstract class SsaImplicitDefinition extends SsaDefinition {`
`217`	`217`	`override predicate hasLocationInfo(`
`218`	`218`	`string filepath, int startline, int startcolumn, int endline, int endcolumn`
`219`	`219`	`) {`
`220`		`- endline = startline and`
`221`		`- endcolumn = startcolumn and`
`222`		`- this.getBasicBlock().hasLocationInfo(filepath, startline, startcolumn, _, _)`
	`220`	`+ this.getBasicBlock().hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)`
`223`	`221`	`}`
`224`	`222`	`}`
`225`	`223`