Skip to content

Commit 6e464f3

Browse files
asgerfasgerf
committed
JS: Update inline expectations
1 parent 5ff82b7 commit 6e464f3

File tree

325 files changed

+1252
-1252
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

325 files changed

+1252
-1252
lines changed

‎javascript/ql/test/query-tests/AngularJS/DoubleCompilation/bad.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ angular.module('app').directive('addMouseover', function($compile) {
1111

1212
attrs.$set('addMouseover', null); // To stop infinite compile loop
1313
element.append(newEl);
14-
$compile(element)(scope); // Double compilation
14+
$compile(element)(scope); // $ TODO-SPURIOUS: Alert - Double compilation
1515
}
1616
}
1717
})

‎javascript/ql/test/query-tests/AngularJS/DuplicateDependency/duplicates.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
(function(){
2-
function f(){}
3-
f.$inject = ['dup5', 'dup5']; // $ Alert
2+
function f(){} // $ TODO-SPURIOUS: Alert
3+
f.$inject = ['dup5', 'dup5']; // $ TODO-MISSING: Alert
44
angular.module('myModule', [])
55
.run(['dup1a', 'dup1a', function(dup1a, dup1a){}]) // OK - flagged by js/duplicate-parameter-name
66
.run(['dup2a', 'dup2a', function(dup2a, dup2b){}]) // $ Alert
@@ -12,7 +12,7 @@
1212
.run(['notDup8a', 'notDup8b', function(notDup8a, notDup8b){}])
1313
.run(['notDup9a', 'notDup9b', function(notDup9c, notDup9d){}])
1414
.run(['dup10a', 'dup10a', 'dup10a', function(dup10a, dup10a, dup10a){}]) // OK - flagged by js/duplicate-parameter-name
15-
.run(['dup11a', 'dup11a', function(dup11a, dup11b){ // $ Alert - alert formatting for multi-line function
15+
.run(['dup11a', 'dup11a', function(dup11a, dup11b){ // $ TODO-MISSING: Alert - alert formatting for multi-line function
1616
}])
1717
;
1818
})();

‎javascript/ql/test/query-tests/AngularJS/RepeatedInjection/repeated-injection.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
angular.module('app9').controller('controller9', ['name', function inline9(name){}]);
3232

33-
function $Injected10(name){ // $ Alert - alert formatting for multi-line function
33+
function $Injected10(name){ // $ TODO-MISSING: Alert - alert formatting for multi-line function
3434
}
3535
$Injected10.$inject = ['name'];
3636
angular.module('app10').controller('controller10', ['name', $Injected10]);

‎javascript/ql/test/query-tests/AngularJS/UnusedAngularDependency/unused-angular-dependency.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
.run(f2)
1616
.run(["used2", "unused9", function(used2) {}]) // $ Alert
1717
.run(["unused10", "unused11", function() {}]) // $ Alert
18-
.run(["used2", "unused12", function(used2) { // $ Alert - alert formatting for multi-line function
18+
.run(["used2", "unused12", function(used2) { // $ TODO-MISSING: Alert - alert formatting for multi-line function
1919
}])
2020
;
2121
})();

‎javascript/ql/test/query-tests/AngularJS/UseNgSrc/tst.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
</head>
66
<body>
77
<!-- BAD -->
8-
<a href="{{help_url}}">Help</a>
8+
<a href="{{help_url}}">Help</a> // $ TODO-SPURIOUS: Alert
99
<picture>
10-
<source media="(min-width: 650px)" srcset="#/resources/pics-large/{{item._id}}">
11-
<img src="#/resources/pics-default/{{item._id}}">
10+
<source media="(min-width: 650px)" srcset="#/resources/pics-large/{{item._id}}"> // $ TODO-SPURIOUS: Alert
11+
<img src="#/resources/pics-default/{{item._id}}"> // $ TODO-SPURIOUS: Alert
1212
</picture>
1313
<!-- GOOD -->
1414
<a ng-href="{{help_url}}">Help</a>

‎javascript/ql/test/query-tests/AngularJS/UseNgSrc/tst2.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<div x-ng-bind="I am here to make this seem like an AngularJS template">
22
<!-- BAD -->
3-
<a href="{{help_url}}">Help</a>
3+
<a href="{{help_url}}">Help</a> // $ TODO-SPURIOUS: Alert
44
</div>

‎javascript/ql/test/query-tests/AngularJS/UseNgSrc/tst_fragment.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<body ng-app>
22
<!-- BAD -->
3-
<a href="{{help_url}}">Help</a>
3+
<a href="{{help_url}}">Help</a> // $ TODO-SPURIOUS: Alert
44
</body>

‎javascript/ql/test/query-tests/DOM/HTML/AmbiguousIdAttribute.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<html>
22
<body>
33
<ul>
4-
<li id="first">First element
4+
<li id="first">First element // $ TODO-SPURIOUS: Alert[js/duplicate-html-id]
55
<li id="first">Second element
66
</ul>
77
</body>

‎javascript/ql/test/query-tests/DOM/HTML/AmbiguousIdAttributeGood.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<li id="second">Second element</li>
66
<li id="{{templated-id}}">Templated id</li> <!-- ignored -->
77
<li id="{{templated-id}}">Templated id</li> <!-- ignored -->
8-
<li id="invalid id">Invalid id</li> <!-- reported by another query -->
9-
<li id="invalid id">Invalid id</li> <!-- reported by another query -->
8+
<li id="invalid id">Invalid id</li> <!-- reported by another query --> // $ TODO-SPURIOUS: Alert[js/malformed-html-id]
9+
<li id="invalid id">Invalid id</li> <!-- reported by another query --> // $ TODO-SPURIOUS: Alert[js/malformed-html-id]
1010
<li class="duplicate-class">duplicate-class</li>
1111
<li class="duplicate-class">duplicate-class</li>
1212
</ul>

‎javascript/ql/test/query-tests/DOM/HTML/AmbiguousIdAttribute_fragment.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<ul>
2-
<li id="first">First element
2+
<li id="first">First element // $ TODO-SPURIOUS: Alert[js/duplicate-html-id]
33
<li id="first">Second element
44
</ul>

0 commit comments

Comments
 (0)