Skip to content

Commit 7bf4a47

Browse files
yoffadityasharad
andauthored
Apply suggestions from code review
Co-authored-by: Aditya Sharad <[email protected]>
1 parent 80ae879 commit 7bf4a47

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

actions/ql/lib/codeql/actions/config/Config.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ predicate untrustedGhCommandDataModel(string cmd_regex, string flag) {
158158
/**
159159
* MaD models for permissions needed by actions
160160
* Fields:
161-
* - action: action name
162-
* - permission: permission name
161+
* - action: action name, e.g. `actions/checkout`
162+
* - permission: permission name, e.g. `contents: read`
163163
*/
164164
predicate actionsPermissionsDataModel(string action, string permission) {
165165
Extensions::actionsPermissionsDataModel(action, permission)

actions/ql/lib/codeql/actions/config/ConfigExtensions.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,5 +85,6 @@ extensible predicate untrustedGhCommandDataModel(string cmd_regex, string flag);
8585
* - `permission` is of the form `scope-name: read|write`, for example `contents: read`.
8686
* - see https://github.com/actions/checkout?tab=readme-ov-file#recommended-permissions
8787
* for an example of recommended permissions.
88+
* - see https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token for documentation of token permissions.
8889
*/
8990
extensible predicate actionsPermissionsDataModel(string action, string permission);

0 commit comments

Comments
 (0)