Skip to content

Commit a35ed57

Browse files
committed
Revert "C++: Don't generate parameter nodes for bodyless parameters when there is a summary of the enclosing function."
This reverts commit ad80b36.
1 parent ff9a4d0 commit a35ed57

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,7 @@ class CastNode extends Node {
10091009
}
10101010

10111011
cached
1012-
newtype TDataFlowCallable =
1012+
private newtype TDataFlowCallable =
10131013
TSourceCallable(Cpp::Declaration decl) or
10141014
TSummarizedCallable(FlowSummaryImpl::Public::SummarizedCallable c)
10151015

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ private newtype TIRDataFlowNode =
6666
TFinalGlobalValue(Ssa::GlobalUse globalUse) or
6767
TInitialGlobalValue(Ssa::GlobalDef globalUse) or
6868
TBodyLessParameterNodeImpl(Parameter p, int indirectionIndex) {
69-
not exists(TSummarizedCallable(p.getFunction())) and
7069
// Rule out parameters of catch blocks.
7170
not exists(p.getCatchBlock()) and
7271
// We subtract one because `getMaxIndirectionsForType` returns the maximum

0 commit comments

Comments
 (0)