Skip to content

Commit d97d673

Browse files
committed
JS: Add test case showing lack of flow through non-sanitising regexp
1 parent 93b1114 commit d97d673

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

javascript/ql/test/library-tests/TaintTracking/DataFlowTracking.expected

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ flow
161161
| partialCalls.js:4:17:4:24 | source() | partialCalls.js:30:14:30:20 | x.value |
162162
| partialCalls.js:4:17:4:24 | source() | partialCalls.js:41:10:41:18 | id(taint) |
163163
| partialCalls.js:4:17:4:24 | source() | partialCalls.js:51:14:51:14 | x |
164+
| regexp-sanitiser.js:2:19:2:26 | source() | regexp-sanitiser.js:4:14:4:18 | taint |
164165
| sanitizer-function.js:12:17:12:24 | source() | sanitizer-function.js:14:10:14:14 | taint |
165166
| sanitizer-function.js:12:17:12:24 | source() | sanitizer-function.js:17:14:17:18 | taint |
166167
| sanitizer-function.js:12:17:12:24 | source() | sanitizer-function.js:21:14:21:18 | taint |
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
function foo() {
2+
const taint = source();
3+
if (/^asd[\s\S]*$/.test(taint)) {
4+
sink(taint); // NOT OK [INCONSISTENCY]
5+
}
6+
}

0 commit comments

Comments
 (0)