Code quality improvement

tamasvajk · tamasvajk · commit f20812d8adc5 · 2024-04-22T15:12:01.000+02:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/Sdk.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/Sdk.cs
@@ -55,14 +55,14 @@ private static HashSet<DotNetVersion> ParseSdks(IList<string> listed)
 
         private string? GetCscPath()
         {
-            var newestSdkVersion = GetNewestSdkVersion();
-            if (newestSdkVersion is null)
+            var version = Version;
+            if (version is null)
             {
                 logger.LogWarning("No dotnet SDK found.");
                 return null;
             }
 
-            var path = Path.Combine(newestSdkVersion.FullPath, "Roslyn", "bincore", "csc.dll");
+            var path = Path.Combine(version.FullPath, "Roslyn", "bincore", "csc.dll");
             logger.LogDebug($"Source generator CSC: '{path}'");
             if (!File.Exists(path))
             {

Original file line number	Diff line number	Diff line change
`@@ -55,14 +55,14 @@ private static HashSet<DotNetVersion> ParseSdks(IList<string> listed)`
`55`	`55`
`56`	`56`	`private string? GetCscPath()`
`57`	`57`	`{`
`58`		`- var newestSdkVersion = GetNewestSdkVersion();`
`59`		`- if (newestSdkVersion is null)`
	`58`	`+ var version = Version;`
	`59`	`+ if (version is null)`
`60`	`60`	`{`
`61`	`61`	`logger.LogWarning("No dotnet SDK found.");`
`62`	`62`	`return null;`
`63`	`63`	`}`
`64`	`64`
`65`		`- var path = Path.Combine(newestSdkVersion.FullPath, "Roslyn", "bincore", "csc.dll");`
	`65`	`+ var path = Path.Combine(version.FullPath, "Roslyn", "bincore", "csc.dll");`
`66`	`66`	`logger.LogDebug($"Source generator CSC: '{path}'");`
`67`	`67`	`if (!File.Exists(path))`
`68`	`68`	`{`