Skip to content

Commit f5f0918

Browse files
authored
Merge pull request #19808 from tamasvajk/quality/extended-suite
Add code-quality-extended query suites
2 parents ee9ceb5 + 94052f1 commit f5f0918

File tree

33 files changed

+169
-13
lines changed

33 files changed

+169
-13
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

actions/ql/integration-tests/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['actions-code-quality.qls', 'actions-security-and-quality.qls', 'actions-security-extended.qls', 'actions-code-scanning.qls']
5+
well_known_query_suites = ['actions-code-quality.qls', 'actions-code-quality-extended.qls', 'actions-security-and-quality.qls', 'actions-security-extended.qls', 'actions-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

cpp/ql/integration-tests/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['cpp-code-quality.qls', 'cpp-security-and-quality.qls', 'cpp-security-extended.qls', 'cpp-code-scanning.qls']
5+
well_known_query_suites = ['cpp-code-quality.qls', 'cpp-code-quality-extended.qls', 'cpp-security-and-quality.qls', 'cpp-security-extended.qls', 'cpp-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers
Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
ql/csharp/ql/src/API Abuse/CallToGCCollect.ql
2+
ql/csharp/ql/src/API Abuse/CallToObsoleteMethod.ql
3+
ql/csharp/ql/src/API Abuse/ClassImplementsICloneable.ql
4+
ql/csharp/ql/src/API Abuse/FormatInvalid.ql
5+
ql/csharp/ql/src/API Abuse/NoDisposeCallOnLocalIDisposable.ql
6+
ql/csharp/ql/src/API Abuse/NullArgumentToEquals.ql
7+
ql/csharp/ql/src/ASP/BlockCodeResponseWrite.ql
8+
ql/csharp/ql/src/Bad Practices/CallsUnmanagedCode.ql
9+
ql/csharp/ql/src/Bad Practices/CatchOfNullReferenceException.ql
10+
ql/csharp/ql/src/Bad Practices/Control-Flow/ConstantCondition.ql
11+
ql/csharp/ql/src/Bad Practices/Declarations/LocalScopeVariableShadowsMember.ql
12+
ql/csharp/ql/src/Bad Practices/EmptyCatchBlock.ql
13+
ql/csharp/ql/src/Bad Practices/Implementation Hiding/ExposeRepresentation.ql
14+
ql/csharp/ql/src/Bad Practices/Naming Conventions/FieldMasksSuperField.ql
15+
ql/csharp/ql/src/Bad Practices/Naming Conventions/SameNameAsSuper.ql
16+
ql/csharp/ql/src/Bad Practices/PathCombine.ql
17+
ql/csharp/ql/src/Bad Practices/UnmanagedCodeCheck.ql
18+
ql/csharp/ql/src/CSI/CompareIdenticalValues.ql
19+
ql/csharp/ql/src/CSI/NullAlways.ql
20+
ql/csharp/ql/src/CSI/NullMaybe.ql
21+
ql/csharp/ql/src/Concurrency/FutileSyncOnField.ql
22+
ql/csharp/ql/src/Concurrency/LockOrder.ql
23+
ql/csharp/ql/src/Concurrency/LockThis.ql
24+
ql/csharp/ql/src/Concurrency/LockedWait.ql
25+
ql/csharp/ql/src/Dead Code/DeadStoreOfLocal.ql
26+
ql/csharp/ql/src/Documentation/XmldocMissingSummary.ql
27+
ql/csharp/ql/src/Language Abuse/CastThisToTypeParameter.ql
28+
ql/csharp/ql/src/Language Abuse/CatchOfGenericException.ql
29+
ql/csharp/ql/src/Language Abuse/DubiousDowncastOfThis.ql
30+
ql/csharp/ql/src/Language Abuse/DubiousTypeTestOfThis.ql
31+
ql/csharp/ql/src/Language Abuse/MissedReadonlyOpportunity.ql
32+
ql/csharp/ql/src/Language Abuse/MissedTernaryOpportunity.ql
33+
ql/csharp/ql/src/Language Abuse/MissedUsingOpportunity.ql
34+
ql/csharp/ql/src/Language Abuse/NestedIf.ql
35+
ql/csharp/ql/src/Language Abuse/RethrowException.ql
36+
ql/csharp/ql/src/Language Abuse/SimplifyBoolExpr.ql
37+
ql/csharp/ql/src/Language Abuse/UnusedPropertyValue.ql
38+
ql/csharp/ql/src/Likely Bugs/Collections/ContainerLengthCmpOffByOne.ql
39+
ql/csharp/ql/src/Likely Bugs/Collections/ContainerSizeCmpZero.ql
40+
ql/csharp/ql/src/Likely Bugs/Collections/ReadOnlyContainer.ql
41+
ql/csharp/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
42+
ql/csharp/ql/src/Likely Bugs/ConstantComparison.ql
43+
ql/csharp/ql/src/Likely Bugs/DangerousNonShortCircuitLogic.ql
44+
ql/csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql
45+
ql/csharp/ql/src/Likely Bugs/EqualsArray.ql
46+
ql/csharp/ql/src/Likely Bugs/HashedButNoHash.ql
47+
ql/csharp/ql/src/Likely Bugs/ImpossibleArrayCast.ql
48+
ql/csharp/ql/src/Likely Bugs/IncomparableEquals.ql
49+
ql/csharp/ql/src/Likely Bugs/NestedLoopsSameVariable.ql
50+
ql/csharp/ql/src/Likely Bugs/PossibleLossOfPrecision.ql
51+
ql/csharp/ql/src/Likely Bugs/RecursiveEquals.ql
52+
ql/csharp/ql/src/Likely Bugs/ReferenceEqualsOnValueTypes.ql
53+
ql/csharp/ql/src/Likely Bugs/SelfAssignment.ql
54+
ql/csharp/ql/src/Likely Bugs/Statements/EmptyBlock.ql
55+
ql/csharp/ql/src/Likely Bugs/Statements/EmptyLockStatement.ql
56+
ql/csharp/ql/src/Likely Bugs/StaticFieldWrittenByInstance.ql
57+
ql/csharp/ql/src/Likely Bugs/StringBuilderCharInit.ql
58+
ql/csharp/ql/src/Likely Bugs/UncheckedCastInEquals.ql
59+
ql/csharp/ql/src/Linq/MissedAllOpportunity.ql
60+
ql/csharp/ql/src/Linq/MissedCastOpportunity.ql
61+
ql/csharp/ql/src/Linq/MissedOfTypeOpportunity.ql
62+
ql/csharp/ql/src/Linq/MissedSelectOpportunity.ql
63+
ql/csharp/ql/src/Linq/MissedWhereOpportunity.ql
64+
ql/csharp/ql/src/Linq/RedundantSelect.ql
65+
ql/csharp/ql/src/Performance/StringBuilderInLoop.ql
66+
ql/csharp/ql/src/Performance/StringConcatenationInLoop.ql
67+
ql/csharp/ql/src/Performance/UseTryGetValue.ql
68+
ql/csharp/ql/src/Useless code/DefaultToString.ql
69+
ql/csharp/ql/src/Useless code/FutileConditional.ql
70+
ql/csharp/ql/src/Useless code/IntGetHashCode.ql
71+
ql/csharp/ql/src/Useless code/RedundantToStringCall.ql
72+
ql/csharp/ql/src/Useless code/UnusedLabel.ql

csharp/ql/integration-tests/posix/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['csharp-code-quality.qls', 'csharp-security-and-quality.qls', 'csharp-security-extended.qls', 'csharp-code-scanning.qls']
5+
well_known_query_suites = ['csharp-code-quality.qls', 'csharp-code-quality-extended.qls', 'csharp-security-and-quality.qls', 'csharp-security-extended.qls', 'csharp-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
ql/go/ql/src/InconsistentCode/LengthComparisonOffByOne.ql
2+
ql/go/ql/src/InconsistentCode/MissingErrorCheck.ql
3+
ql/go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql
4+
ql/go/ql/src/InconsistentCode/WrappedErrorAlwaysNil.ql
5+
ql/go/ql/src/RedundantCode/NegativeLengthCheck.ql
6+
ql/go/ql/src/RedundantCode/RedundantRecover.ql

go/ql/integration-tests/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['go-code-quality.qls', 'go-security-and-quality.qls', 'go-security-extended.qls', 'go-code-scanning.qls']
5+
well_known_query_suites = ['go-code-quality.qls', 'go-code-quality-extended.qls', 'go-security-and-quality.qls', 'go-security-extended.qls', 'go-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
ql/java/ql/src/Language Abuse/EmptyMethod.ql
2+
ql/java/ql/src/Language Abuse/TypeVariableHidesType.ql
3+
ql/java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
4+
ql/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
5+
ql/java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql
6+
ql/java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql
7+
ql/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
8+
ql/java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql
9+
ql/java/ql/src/Likely Bugs/Frameworks/JUnit/JUnit5MissingNestedAnnotation.ql
10+
ql/java/ql/src/Likely Bugs/Likely Typos/ContradictoryTypeChecks.ql
11+
ql/java/ql/src/Likely Bugs/Likely Typos/SuspiciousDateFormat.ql
12+
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql
13+
ql/java/ql/src/Likely Bugs/Resource Leaks/CloseWriter.ql
14+
ql/java/ql/src/Performance/StringReplaceAllWithNonRegex.ql
15+
ql/java/ql/src/Violations of Best Practice/Undesirable Calls/DoNotCallFinalize.ql

java/ql/integration-tests/java/query-suite/not_included_in_qls.expected

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ ql/java/ql/src/Frameworks/Spring/XML Configuration Errors/MissingSetters.ql
6666
ql/java/ql/src/Language Abuse/CastThisToTypeParameter.ql
6767
ql/java/ql/src/Language Abuse/DubiousDowncastOfThis.ql
6868
ql/java/ql/src/Language Abuse/DubiousTypeTestOfThis.ql
69-
ql/java/ql/src/Language Abuse/EmptyMethod.ql
7069
ql/java/ql/src/Language Abuse/EmptyStatement.ql
7170
ql/java/ql/src/Language Abuse/EnumIdentifier.ql
7271
ql/java/ql/src/Language Abuse/ImplementsAnnotation.ql

java/ql/integration-tests/java/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['java-code-quality.qls', 'java-security-and-quality.qls', 'java-security-extended.qls', 'java-code-scanning.qls']
5+
well_known_query_suites = ['java-code-quality.qls', 'java-code-quality-extended.qls', 'java-security-and-quality.qls', 'java-security-extended.qls', 'java-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql
2+
ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql
3+
ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql
4+
ql/javascript/ql/src/Expressions/MissingAwait.ql
5+
ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql
6+
ql/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql
7+
ql/javascript/ql/src/Quality/UnhandledErrorInStreamPipeline.ql
8+
ql/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql
9+
ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql

javascript/ql/integration-tests/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['javascript-code-quality.qls', 'javascript-security-and-quality.qls', 'javascript-security-extended.qls', 'javascript-code-scanning.qls']
5+
well_known_query_suites = ['javascript-code-quality.qls', 'javascript-code-quality-extended.qls', 'javascript-security-and-quality.qls', 'javascript-security-extended.qls', 'javascript-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
- description: Selectors for selecting the extended code-quality queries for a language
2+
- include:
3+
kind:
4+
- problem
5+
- path-problem
6+
precision:
7+
- high
8+
- very-high
9+
- medium
10+
tags contain:
11+
- quality
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
ql/python/ql/src/Functions/IterReturnsNonSelf.ql
2+
ql/python/ql/src/Functions/NonCls.ql
3+
ql/python/ql/src/Functions/NonSelf.ql
4+
ql/python/ql/src/Functions/ReturnConsistentTupleSizes.ql
5+
ql/python/ql/src/Functions/SignatureSpecialMethods.ql
6+
ql/python/ql/src/Resources/FileNotAlwaysClosed.ql
7+
ql/python/ql/src/Variables/LoopVariableCapture/LoopVariableCapture.ql

python/ql/integration-tests/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['python-code-quality.qls', 'python-security-and-quality.qls', 'python-security-extended.qls', 'python-code-scanning.qls']
5+
well_known_query_suites = ['python-code-quality.qls', 'python-code-quality-extended.qls', 'python-security-and-quality.qls', 'python-security-extended.qls', 'python-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
ql/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql
2+
ql/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql
3+
ql/ruby/ql/src/queries/variables/UninitializedLocal.ql

ruby/ql/integration-tests/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['ruby-code-quality.qls', 'ruby-security-and-quality.qls', 'ruby-security-extended.qls', 'ruby-code-scanning.qls']
5+
well_known_query_suites = ['ruby-code-quality.qls', 'ruby-code-quality-extended.qls', 'ruby-security-and-quality.qls', 'ruby-security-extended.qls', 'ruby-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers

rust/ql/integration-tests/query-suite/not_included_in_qls.expected

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ ql/rust/ql/src/queries/summary/LinesOfUserCodeInFiles.ql
33
ql/rust/ql/src/queries/summary/QuerySinks.ql
44
ql/rust/ql/src/queries/summary/SensitiveData.ql
55
ql/rust/ql/src/queries/summary/TaintSources.ql
6-
ql/rust/ql/src/queries/unusedentities/UnreachableCode.ql
7-
ql/rust/ql/src/queries/unusedentities/UnusedValue.ql
86
ql/rust/ql/src/utils/modelgenerator/CaptureContentSummaryModels.ql
97
ql/rust/ql/src/utils/modelgenerator/CaptureNeutralModels.ql
108
ql/rust/ql/src/utils/modelgenerator/CaptureSinkModels.ql
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
ql/rust/ql/src/queries/unusedentities/UnreachableCode.ql
2+
ql/rust/ql/src/queries/unusedentities/UnusedValue.ql
3+
ql/rust/ql/src/queries/unusedentities/UnusedVariable.ql

rust/ql/integration-tests/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['rust-code-quality.qls', 'rust-security-and-quality.qls', 'rust-security-extended.qls', 'rust-code-scanning.qls']
5+
well_known_query_suites = ['rust-code-quality.qls', 'rust-code-quality-extended.qls', 'rust-security-and-quality.qls', 'rust-security-extended.qls', 'rust-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

swift/ql/integration-tests/posix/query-suite/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import pytest
33
from query_suites import *
44

5-
well_known_query_suites = ['swift-code-quality.qls', 'swift-security-and-quality.qls', 'swift-security-extended.qls', 'swift-code-scanning.qls']
5+
well_known_query_suites = ['swift-code-quality.qls', 'swift-code-quality-extended.qls', 'swift-security-and-quality.qls', 'swift-security-extended.qls', 'swift-code-scanning.qls']
66

77
@runs_on.posix
88
@pytest.mark.parametrize("query_suite", well_known_query_suites)
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- queries: .
2+
- apply: code-quality-extended-selectors.yml
3+
from: codeql/suite-helpers

0 commit comments

Comments
 (0)