Merge pull request #18874 from github/alexet/simplify-interpretoutput

alexet · web-flow · commit f7d95e4dcbbe · 2025-02-27T12:31:39.000Z
Java: Simplify interpretOutput
diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll b/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll
@@ -301,7 +301,7 @@ module SourceSinkInterpretationInput implements
       ast = mid.asElement()
     |
       (c = "Parameter" or c = "") and
-      node.asNode().asParameter() = mid.asElement()
+      n.asParameter() = ast
       or
       c = "" and
       n.asExpr().(FieldRead).getField() = ast

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ module SourceSinkInterpretationInput implements`
`301`	`301`	`ast = mid.asElement()`
`302`	`302`	`\|`
`303`	`303`	`(c = "Parameter" or c = "") and`
`304`		`- node.asNode().asParameter() = mid.asElement()`
	`304`	`+ n.asParameter() = ast`
`305`	`305`	`or`
`306`	`306`	`c = "" and`
`307`	`307`	`n.asExpr().(FieldRead).getField() = ast`