C#: Address review comments.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp/Entities/Types/Type.cs

@@ -25,6 +25,20 @@ public static bool ConstructedOrParentIsConstructed(INamedTypeSymbol symbol)
                 symbol.ContainingType is not null && ConstructedOrParentIsConstructed(symbol.ContainingType);
         }
 
+
+        /// <summary>
+        /// A hashset containing the C# contextual keywords that could be confused with types (and typing).
+        ///
+        /// For the list of all contextual keywords, see
+        /// https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/#contextual-keywords
+        /// </summary>
+        private readonly HashSet<string> ContextualKeywordTypes = [
+            "dynamic",
+            "nint",
+            "nuint",
+            "var"
+            ];
+
         /// <summary>
         /// Returns true in case we suspect this is a broken type.
         /// </summary>
@@ -40,8 +54,9 @@ private bool IsBrokenType(ITypeSymbol symbol)
 
             // (1) public class { ... } is a broken type as it doesn't have a name.
             // (2) public class var { ... } is an allowed type, but it overrides the `var` keyword for all uses.
-            //     It is probably a better heuristic to treat it as a broken type.
-            return string.IsNullOrEmpty(symbol.Name) || symbol.Name == "var";
+            //     The same goes for other contextual keywords that could be used as type names.
+            //     It is probably a better heuristic to treat these as broken types.
+            return string.IsNullOrEmpty(symbol.Name) || ContextualKeywordTypes.Contains(symbol.Name);
         }
 
         public Kinds.TypeKind GetTypeKind(Context cx, bool constructUnderlyingTupleType)

csharp/extractor/Semmle.Extraction.CSharp/Extractor/BinaryLogExtractionContext.cs

@@ -47,7 +47,7 @@ public BinaryLogExtractionContext(string cwd, string[] args, string outputPath,
 
         public static string? GetAdjustedPath(ExtractionContext extractionContext, string sourcePath)
         {
-            if (extractionContext.Mode.HasFlag(ExtractorMode.BinaryLog)
+            if (extractionContext.IsBinaryLog
                 && extractionContext is BinaryLogExtractionContext binaryLogExtractionContext
                 && binaryLogExtractionContext.GetAdjustedPath(sourcePath) is string adjustedPath)
             {

csharp/extractor/Semmle.Extraction.CSharp/Extractor/ExtractionContext.cs

@@ -16,6 +16,7 @@ public class ExtractionContext
         public string OutputPath { get; }
         public IEnumerable<CompilationInfo> CompilationInfos { get; }
         public bool IsStandalone => Mode.HasFlag(ExtractorMode.Standalone);
+        public bool IsBinaryLog => Mode.HasFlag(ExtractorMode.BinaryLog);
 
         /// <summary>
         /// Creates a new extractor instance for one compilation unit.