Skip to content

Commit 8f6a85b

Browse files
authored
Merge pull request #37015 from github/repo-sync
Repo sync
2 parents 318a239 + d96e04d commit 8f6a85b

File tree

4 files changed

+36
-7
lines changed

4 files changed

+36
-7
lines changed

.github/workflows/ready-for-doc-review.yml

+7-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,12 @@ jobs:
5050
GITHUB_TOKEN: ${{ secrets.DOCS_BOT_PAT_WRITEORG_PROJECT }}
5151
run: |
5252
echo "Extracting issue numbers from PR description..."
53-
ISSUE_NUMS=$(echo "${{ github.event.pull_request.body }}" | grep -oE '(https://github.com/github/docs-content/issues/[0-9]+|github/docs-content#[0-9]+|#[0-9]+)' | grep -oE '[0-9]+$')
53+
54+
# Clean up PR description to avoid syntax errors in grep command
55+
PR_BODY="${{ github.event.pull_request.body }}"
56+
echo "PR description to use in the script: $PR_BODY"
57+
58+
ISSUE_NUMS=$(echo "$PR_BODY" | grep -oE '(https://github.com/github/docs-content/issues/[0-9]+|github/docs-content#[0-9]+|#[0-9]+)' | grep -oE '[0-9]+$')
5459
echo "Extracted issue numbers: $ISSUE_NUMS"
5560
5661
if [ -n "$ISSUE_NUMS" ]; then
@@ -67,7 +72,7 @@ jobs:
6772
echo "DIY_DOCS_LABEL=true" >> $GITHUB_ENV
6873
break
6974
else
70-
echo "DIY docs label not found for issue #$ISSUE_NUM."
75+
echo "DIY docs label not found for issue $ISSUE_NUM."
7176
fi
7277
else
7378
echo "Issue $ISSUE_NUM does not exist in the docs-content repository."

config/moda/configuration/default/env.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ data:
44
NODE_OPTIONS: '--max-old-space-size=4096'
55
PORT: '4000'
66
ENABLED_LANGUAGES: 'en,es,ja,pt,zh,ru,fr,ko,de'
7-
RATE_LIMIT_MAX: '21'
7+
RATE_LIMIT_MAX: '150'
88
# Moda uses a non-default port for sending datadog metrics
99
DD_DOGSTATSD_PORT: '28125'

content/actions/security-for-github-actions/using-artifact-attestations/using-artifact-attestations-to-establish-provenance-for-builds.md

+28-2
Original file line numberDiff line numberDiff line change
@@ -177,12 +177,20 @@ When you run your updated workflows, they will build your artifacts and generate
177177

178178
## Verifying artifact attestations with the {% data variables.product.prodname_cli %}
179179

180+
You can validate artifact attestations for binaries and container images and validate SBOM attestations using the {% data variables.product.prodname_cli %}. For more information, see the [`attestation`](https://cli.github.com/manual/gh_attestation) section of the {% data variables.product.prodname_cli %} manual.
181+
182+
>[!NOTE]These commands assume you are in an online environment. If you are in an offline or air-gapped environment, see [AUTOTITLE](/actions/security-guides/verifying-attestations-offline).
183+
184+
### Verifying an artifact attestation for binaries
185+
180186
To verify artifact attestations for **binaries**, use the following {% data variables.product.prodname_cli %} command.
181187

182188
```bash copy
183189
gh attestation verify PATH/TO/YOUR/BUILD/ARTIFACT-BINARY -R ORGANIZATION_NAME/REPOSITORY_NAME
184190
```
185191

192+
### Verifying an artifact attestation for container images
193+
186194
To verify artifact attestations for **container images**, you must provide the image's FQDN prefixed with `oci://` instead of the path to a binary. You can use the following {% data variables.product.prodname_cli %} command.
187195

188196
```bash copy
@@ -191,6 +199,24 @@ docker login ghcr.io
191199
gh attestation verify oci://ghcr.io/ORGANIZATION_NAME/IMAGE_NAME:test -R ORGANIZATION_NAME/REPOSITORY_NAME
192200
```
193201

194-
>[!NOTE]These commands assume you are in an online environment. If you are in an offline or air-gapped environment, see [AUTOTITLE](/actions/security-guides/verifying-attestations-offline).
202+
### Verifying an attestation for SBOMs
203+
204+
To verify SBOM attestations, you have to provide the `--predicate-type` flag to reference a non-default predicate. For more information, see [Vetted predicates](https://github.com/in-toto/attestation/tree/main/spec/predicates#vetted-predicates) in the `in-toto/attestation` repository.
195205

196-
For more information, see the [`attestation`](https://cli.github.com/manual/gh_attestation) section of the {% data variables.product.prodname_cli %} manual.
206+
For example, the [`attest-sbom` action](https://github.com/actions/attest-sbom) currently supports either SPDX or CycloneDX SBOM predicates. To verify an SBOM attestation in the SPDX format, you can use the following {% data variables.product.prodname_cli %} command.
207+
208+
```bash copy
209+
gh attestation verify PATH/TO/YOUR/BUILD/ARTIFACT-BINARY \
210+
-R ORGANIZATION_NAME/REPOSITORY_NAME \
211+
--predicate-type https://spdx.dev/Document/v2.3
212+
```
213+
214+
To view more information on the attestation, reference the `--format json` flag. This can be especially helpful when reviewing SBOM attestations.
215+
216+
```bash copy
217+
gh attestation verify PATH/TO/YOUR/BUILD/ARTIFACT-BINARY \
218+
-R ORGANIZATION_NAME/REPOSITORY_NAME \
219+
--predicate-type https://spdx.dev/Document/v2.3 \
220+
--format json \
221+
--jq '.[].verificationResult.statement.predicate'
222+
```

src/shielding/middleware/rate-limit.ts

-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ if (isNaN(MAX)) {
1414
}
1515

1616
// We apply this rate limiter to _all_ routes in src/shielding/index.ts except for `/api/*` routes
17-
// `/api/*` routes are rate limited on a more specific basis in frame/api/index.ts
18-
// When creating a limiter for `/api/*` routes, we need to pass `true` as the second argument
1917
export function createRateLimiter(max = MAX, isAPILimiter = false) {
2018
return rateLimit({
2119
// 1 minute

0 commit comments

Comments
 (0)