Skip to content

Commit 8a0b80c

Browse files
committed
remove autocorrecting"
1 parent ef585ab commit 8a0b80c

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

lib/rules/no-inner-html.js

+1-8
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ module.exports = {
55
description: 'disallow `Element.prototype.innerHTML` in favor of `Element.prototype.textContent`',
66
url: require('../url')(module)
77
},
8-
fixable: 'code',
98
schema: []
109
},
1110

@@ -14,13 +13,7 @@ module.exports = {
1413
'MemberExpression[property.name=innerHTML]': function (node) {
1514
context.report({
1615
node: node.property,
17-
meta: {
18-
fixable: 'code'
19-
},
20-
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.',
21-
fix(fixer) {
22-
return fixer.replaceText(node.property, 'textContent')
23-
}
16+
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.'
2417
})
2518
}
2619
}

tests/no-inner-html.js

-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ ruleTester.run('no-innter-html', rule, {
1515
invalid: [
1616
{
1717
code: 'document.createElement("js-flash-text").innerHTML = "foo"',
18-
output: 'document.createElement("js-flash-text").textContent = "foo"',
1918
errors: [
2019
{
2120
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.',
@@ -25,7 +24,6 @@ ruleTester.run('no-innter-html', rule, {
2524
},
2625
{
2726
code: 'document.querySelector("js-flash-text").innerHTML = "<div>code</div>"',
28-
output: 'document.querySelector("js-flash-text").textContent = "<div>code</div>"',
2927
errors: [
3028
{
3129
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.',
@@ -35,7 +33,6 @@ ruleTester.run('no-innter-html', rule, {
3533
},
3634
{
3735
code: 'document.querySelector("js-flash-text").innerHTML = ""',
38-
output: 'document.querySelector("js-flash-text").textContent = ""',
3936
errors: [
4037
{
4138
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.',

0 commit comments

Comments
 (0)