Skip to content

Commit 9e07ccc

Browse files
authored
Merge pull request #2 from github/casing
Fix casing issue in new item value
2 parents d9bb0a9 + aceb4b3 commit 9e07ccc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/index.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class FilterInputElement extends HTMLElement {
7171
async function filterResults(filterInput: FilterInputElement, checkCurrentQuery: boolean = false) {
7272
const input = filterInput.input
7373
if (!input) return
74-
const query = input.value.toLowerCase()
74+
const query = input.value.trim()
7575
const id = filterInput.getAttribute('aria-owns')
7676
if (!id) return
7777
const container = document.getElementById(id)
@@ -124,7 +124,7 @@ async function filterResults(filterInput: FilterInputElement, checkCurrentQuery:
124124
}
125125

126126
function matchSubstring(_item: HTMLElement, itemText: string, query: string): MatchResult {
127-
const match = itemText.indexOf(query) !== -1
127+
const match = itemText.toLowerCase().indexOf(query.toLowerCase()) !== -1
128128
return {
129129
match,
130130
hideNew: itemText === query
@@ -133,7 +133,7 @@ function matchSubstring(_item: HTMLElement, itemText: string, query: string): Ma
133133

134134
function getText(filterableItem: HTMLElement) {
135135
const target = filterableItem.querySelector('[data-filter-item-text]') || filterableItem
136-
return (target.textContent || '').trim().toLowerCase()
136+
return (target.textContent || '').trim()
137137
}
138138

139139
function updateNewItem(newItem: HTMLElement, query: string) {

test/test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ describe('filter-input', function() {
5353
assert.equal(customEvent.detail.count, 1)
5454
assert.equal(customEvent.detail.total, 4)
5555

56-
changeValue(input, 'boom')
56+
changeValue(input, 'BB-8 robot')
5757
assert.notOk(newItem.hidden, 'New item form should be shown')
58-
assert.equal(newItem.querySelector('[data-filter-new-item-value]').value, 'boom')
59-
assert.equal(newItem.querySelector('[data-filter-new-item-text]').textContent, 'boom')
58+
assert.equal(newItem.querySelector('[data-filter-new-item-value]').value, 'BB-8 robot')
59+
assert.equal(newItem.querySelector('[data-filter-new-item-text]').textContent, 'BB-8 robot')
6060
})
6161

6262
it('filters and toggles blankslate', async function() {

0 commit comments

Comments
 (0)