Skip to content
This repository was archived by the owner on Jul 2, 2019. It is now read-only.

Commit af8ffbe

Browse files
spearceJunio C Hamano
authored andcommitted
Remove SIMPLE_PROGRAMS and make git-daemon a normal program.
Some platforms (Solaris in particular) appear to require -lz as part of the link line for git-daemon, due to it linking against sha1_file.o and that module requiring inflate/deflate support. So its time to retire SIMPLE_PROGRAMS and move its last remaining member into the standard PROGRAMS list, allowing it to link against all libraries used by the rest of Git. Signed-off-by: Shawn O. Pearce <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent bf8675d commit af8ffbe

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

Makefile

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -185,15 +185,12 @@ SCRIPTS = $(patsubst %.sh,%,$(SCRIPT_SH)) \
185185
$(patsubst %.py,%,$(SCRIPT_PYTHON)) \
186186
git-cherry-pick git-status git-instaweb
187187

188-
# The ones that do not have to link with lcrypto, lz nor xdiff.
189-
SIMPLE_PROGRAMS = \
190-
git-daemon$X
191-
192188
# ... and all the rest that could be moved out of bindir to gitexecdir
193189
PROGRAMS = \
194190
git-convert-objects$X git-fetch-pack$X git-fsck-objects$X \
195191
git-hash-object$X git-index-pack$X git-local-fetch$X \
196192
git-merge-base$X \
193+
git-daemon$X \
197194
git-merge-index$X git-mktag$X git-mktree$X git-patch-id$X \
198195
git-peek-remote$X git-receive-pack$X \
199196
git-send-pack$X git-shell$X \
@@ -215,7 +212,7 @@ BUILT_INS = \
215212
$(patsubst builtin-%.o,git-%$X,$(BUILTIN_OBJS))
216213

217214
# what 'all' will build and 'install' will install, in gitexecdir
218-
ALL_PROGRAMS = $(PROGRAMS) $(SIMPLE_PROGRAMS) $(SCRIPTS) \
215+
ALL_PROGRAMS = $(PROGRAMS) $(SCRIPTS) \
219216
git-merge-recur$X
220217

221218
# Backward compatibility -- to be removed after 1.0
@@ -479,11 +476,9 @@ ifdef NEEDS_LIBICONV
479476
endif
480477
ifdef NEEDS_SOCKET
481478
EXTLIBS += -lsocket
482-
SIMPLE_LIB += -lsocket
483479
endif
484480
ifdef NEEDS_NSL
485481
EXTLIBS += -lnsl
486-
SIMPLE_LIB += -lnsl
487482
endif
488483
ifdef NO_D_TYPE_IN_DIRENT
489484
BASIC_CFLAGS += -DNO_D_TYPE_IN_DIRENT
@@ -728,11 +723,6 @@ endif
728723
git-%$X: %.o $(GITLIBS)
729724
$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIBS)
730725

731-
$(SIMPLE_PROGRAMS) : $(LIB_FILE)
732-
$(SIMPLE_PROGRAMS) : git-%$X : %.o
733-
$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
734-
$(LIB_FILE) $(SIMPLE_LIB)
735-
736726
ssh-pull.o: ssh-fetch.c
737727
ssh-push.o: ssh-upload.c
738728
git-local-fetch$X: fetch.o

0 commit comments

Comments
 (0)