Skip to content

Commit a6570c3

Browse files
committed
fix: linting
- [x] bad indenting - [x] bad code still present - [x] docs - [x] bad f string, single vs double quotes also - [x] line too long, ignoring Signed-off-by: jmeridth <[email protected]>
1 parent 3b13de5 commit a6570c3

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

auth.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def get_github_app_installation_token(
5959
) -> str | None:
6060
"""
6161
Get a GitHub App Installation token.
62-
API: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation
62+
API: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation # noqa: E501
6363
6464
Args:
6565
ghe (str): the GitHub Enterprise endpoint

classes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class IssueWithMetrics:
2121
time_in_draft (timedelta, optional): The time the PR was in draft state.
2222
label_metrics (dict, optional): A dictionary containing the label metrics
2323
mentor_activity (dict, optional): A dictionary containing active mentors
24-
24+
created_at (datetime, optional): The time the issue was created.
2525
"""
2626

2727
# pylint: disable=too-many-instance-attributes

issue_metrics.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,6 @@ def get_per_issue_metrics(
108108
)
109109
else:
110110
num_issues_open += 1
111-
if env_vars.hide_created_at is False:
112-
issue_with_metrics.created_at = issue.created_at
113111
else:
114112
if ignore_users and issue.user["login"] in ignore_users: # type: ignore
115113
continue
@@ -161,10 +159,8 @@ def get_per_issue_metrics(
161159
)
162160
elif issue.state == "open": # type: ignore
163161
num_issues_open += 1
164-
if env_vars.hide_created_at is False:
165-
issue_with_metrics.created_at = issue.created_at
166-
if not env_vars.hide_created_at:
167-
issue_with_metrics.created_at = issue["createdAt"]
162+
if not env_vars.hide_created_at:
163+
issue_with_metrics.created_at = issue["createdAt"]
168164
issues_with_metrics.append(issue_with_metrics)
169165

170166
return issues_with_metrics, num_issues_open, num_issues_closed

markdown_writer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def get_non_hidden_columns(labels) -> List[str]:
8181
columns.append(f"Time spent in {label}")
8282
hide_created_at = env_vars.hide_created_at
8383
if not hide_created_at:
84-
columns.append(f'Created At')
84+
columns.append("Created At")
8585

8686
return columns
8787

0 commit comments

Comments
 (0)