Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv as a dependency for Ruby 3.4+ #786

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

gjtorikian
Copy link
Contributor

@gjtorikian gjtorikian commented Jan 8, 2025

Fixes #752.

As the issue says, the gem can't be used with Ruby 3.4, because csv was taken out of the Ruby standard library. csv is being used by the Gradle source.

@gjtorikian
Copy link
Contributor Author

@dangoor Any chance this can be merged and released?

@dangoor
Copy link
Contributor

dangoor commented Jan 27, 2025

@gjtorikian Thanks for your patience here. We're working on improving the maintenance of this project in the very near term.

I'll try to get your change merged in and released in the meantime, but I am very short on time right now so I can't guarantee it.

@dangoor
Copy link
Contributor

dangoor commented Jan 28, 2025

@gjtorikian Sorry, I'm running out of time on this. Can you run licensed cache to add the metadata for csv?

@gjtorikian
Copy link
Contributor Author

Sure thing, done.

@dangoor
Copy link
Contributor

dangoor commented Jan 29, 2025

@gjtorikian I don't know why licensed called the license other for csv, because it is clearly BSD-2-Clause. Because it showed up as other, we need to add it to the reviewed section of licensed.yml. Can you make that change?

@gjtorikian
Copy link
Contributor Author

done, and rebased !

@dangoor
Copy link
Contributor

dangoor commented Jan 29, 2025

@gjtorikian Sorry to say it, but I'm wary of merging the CI failure. It looks completely unrelated... Unfortunately, I didn't get a chance to finish this up (or finish moving this into its new community-driven org) before I'm going to be unavailable for a few days. I'll look to get this picked back up next week (unless someone else happens to get to it before me).

licensed should be in a better place for community contribution soon!

Copy link
Contributor

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjtorikian!

@MikeMcQuaid
Copy link
Contributor

Merging as this is a known problem and none of these failing CI jobs bear any resemblance to what's been actually changed (Ruby) and the majority are passing.

@MikeMcQuaid MikeMcQuaid merged commit 951a7ef into licensee:main Feb 6, 2025
33 of 47 checks passed
@gjtorikian
Copy link
Contributor Author

Thanks Mike. Any chance for a new release cut?

@MikeMcQuaid
Copy link
Contributor

@gjtorikian I'm planning it in the next few hours!

@MikeMcQuaid
Copy link
Contributor

@gjtorikian v5.0.2 was just released with this PR.

@gjtorikian
Copy link
Contributor Author

thank you~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CSV inclusion warning for Ruby 3.4.0
4 participants