-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add csv
as a dependency for Ruby 3.4+
#786
Conversation
@dangoor Any chance this can be merged and released? |
@gjtorikian Thanks for your patience here. We're working on improving the maintenance of this project in the very near term. I'll try to get your change merged in and released in the meantime, but I am very short on time right now so I can't guarantee it. |
@gjtorikian Sorry, I'm running out of time on this. Can you run |
Sure thing, done. |
@gjtorikian I don't know why licensed called the license |
done, and rebased ! |
@gjtorikian Sorry to say it, but I'm wary of merging the CI failure. It looks completely unrelated... Unfortunately, I didn't get a chance to finish this up (or finish moving this into its new community-driven org) before I'm going to be unavailable for a few days. I'll look to get this picked back up next week (unless someone else happens to get to it before me). licensed should be in a better place for community contribution soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gjtorikian!
Merging as this is a known problem and none of these failing CI jobs bear any resemblance to what's been actually changed (Ruby) and the majority are passing. |
Thanks Mike. Any chance for a new release cut? |
@gjtorikian I'm planning it in the next few hours! |
@gjtorikian v5.0.2 was just released with this PR. |
thank you~! |
Fixes #752.
As the issue says, the gem can't be used with Ruby 3.4, because
csv
was taken out of the Ruby standard library.csv
is being used by the Gradle source.