Skip to content

Commit c6e4e15

Browse files
authored
Merge branch 'master' into image-button
2 parents e54c17d + 931dbeb commit c6e4e15

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

Diff for: index.js

+4
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ class MarkdownHeaderButtonElement extends MarkdownButtonElement {
4545
super()
4646

4747
const level = parseInt(this.getAttribute('level') || 3, 10)
48+
if (level < 1 || level > 6) {
49+
return
50+
}
51+
4852
const prefix = `${'#'.repeat(level)} `
4953
styles.set(this, {
5054
prefix

Diff for: package-lock.json

+7-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: test/test.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
describe('markdown-toolbbar-element', function() {
1+
describe('markdown-toolbar-element', function() {
22
describe('element creation', function() {
33
it('creates from document.createElement', function() {
44
const el = document.createElement('markdown-toolbar')
@@ -71,6 +71,7 @@ describe('markdown-toolbbar-element', function() {
7171
<md-bold>bold</md-bold>
7272
<md-header>header</md-header>
7373
<md-header level="1">h1</md-header>
74+
<md-header level="10">h1</md-header>
7475
<md-italic>italic</md-italic>
7576
<md-quote>quote</md-quote>
7677
<md-code>code</md-code>
@@ -524,11 +525,18 @@ describe('markdown-toolbbar-element', function() {
524525
clickToolbar('md-header')
525526
assert.equal('### |title|', visualValue())
526527
})
528+
527529
it('inserts header 1 syntax with cursor in description', function() {
528530
setVisualValue('|title|')
529531
clickToolbar('md-header[level="1"]')
530532
assert.equal('# |title|', visualValue())
531533
})
534+
535+
it('does not insert header for invalid level', function() {
536+
setVisualValue('|title|')
537+
clickToolbar('md-header[level="10"]')
538+
assert.equal('|title|', visualValue())
539+
})
532540
})
533541
})
534542
})

0 commit comments

Comments
 (0)