Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit b5d6f48

Browse files
authored
Remove pointer to invalid enums.CLIENT_VERSION (optimizely#224)
1 parent a0b3462 commit b5d6f48

File tree

4 files changed

+2
-2
lines changed

4 files changed

+2
-2
lines changed

Diff for: packages/optimizely-sdk/lib/index.browser.js

-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ module.exports = {
7171

7272
config = fns.assignIn({
7373
clientEngine: enums.JAVASCRIPT_CLIENT_ENGINE,
74-
clientVersion: enums.CLIENT_VERSION,
7574
errorHandler: defaultErrorHandler,
7675
eventDispatcher: defaultEventDispatcher,
7776
logger: logger.createLogger({logLevel: logLevel})

Diff for: packages/optimizely-sdk/lib/index.browser.tests.js

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ describe('javascript-sdk', function() {
8282
});
8383

8484
assert.instanceOf(optlyInstance, Optimizely);
85+
assert.equal(optlyInstance.clientVersion, '3.0.0');
8586
});
8687

8788
it('should set the JavaScript client engine and version', function() {

Diff for: packages/optimizely-sdk/lib/index.node.js

-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ module.exports = {
6666

6767
config = fns.assign({
6868
clientEngine: enums.NODE_CLIENT_ENGINE,
69-
clientVersion: enums.CLIENT_VERSION,
7069
errorHandler: defaultErrorHandler,
7170
eventDispatcher: defaultEventDispatcher,
7271
jsonSchemaValidator: jsonSchemaValidator,

Diff for: packages/optimizely-sdk/lib/index.node.tests.js

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ describe('optimizelyFactory', function() {
7878
});
7979

8080
assert.instanceOf(optlyInstance, Optimizely);
81+
assert.equal(optlyInstance.clientVersion, '3.0.0');
8182
});
8283
});
8384
});

0 commit comments

Comments
 (0)