Skip to content

Commit 0582fdf

Browse files
authored
Merge pull request #5 from github/events
Update event name and docs
2 parents 493d3d2 + 3e9e4d9 commit 0582fdf

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ import '@github/task-lists-element'
4545
```js
4646
const list = document.querySelector('task-lists')
4747

48-
list.addEventListener('task-lists:check', function(event) {
48+
list.addEventListener('task-lists-check', function(event) {
4949
const {position, checked} = event.detail
5050
console.log(position, checked)
5151
})
5252

53-
list.addEventListener('task-lists:move', function(event) {
53+
list.addEventListener('task-lists-move', function(event) {
5454
const {src, dst} = event.detail
5555
console.log(src, dst)
5656
})

examples/index.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,12 @@
6262
<pre class="events"></pre>
6363
<script type="text/javascript">
6464
const events = document.querySelector('.events')
65-
document.addEventListener('task-lists:check', function(event) {
66-
events.append(`task-lists:check - checked: ${event.detail.checked}, position: ${event.detail.position}\n`)
65+
document.addEventListener('task-lists-check', function(event) {
66+
events.append(`task-lists-check - checked: ${event.detail.checked}, position: ${event.detail.position}\n`)
6767
})
6868

69-
document.addEventListener('task-lists:move', function(event) {
70-
events.append(`task-lists:move - from: ${event.detail.src}, to: ${event.detail.dst}\n`)
69+
document.addEventListener('task-lists-move', function(event) {
70+
events.append(`task-lists-move - from: ${event.detail.src}, to: ${event.detail.dst}\n`)
7171
})
7272
</script>
7373
</body>

src/task-lists-element.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default class TaskListsElement extends HTMLElement {
1414
if (!checkbox.classList.contains('task-list-item-checkbox')) return
1515

1616
this.dispatchEvent(
17-
new CustomEvent('task-lists:check', {
17+
new CustomEvent('task-lists-check', {
1818
bubbles: true,
1919
detail: {
2020
position: position(checkbox),
@@ -207,7 +207,7 @@ function onSorted({src, dst}) {
207207
originalLists.delete(container)
208208

209209
container.dispatchEvent(
210-
new CustomEvent('task-lists:move', {
210+
new CustomEvent('task-lists-move', {
211211
bubbles: true,
212212
detail: {
213213
src: [lists.indexOf(src.list), src.index],

test/test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ describe('task-lists element', function() {
6969
let called = false
7070

7171
const list = document.querySelector('task-lists')
72-
list.addEventListener('task-lists:check', function(event) {
72+
list.addEventListener('task-lists-check', function(event) {
7373
called = true
7474
const {position, checked} = event.detail
7575
assert.deepEqual(position, [1, 1])
@@ -87,7 +87,7 @@ describe('task-lists element', function() {
8787
let called = false
8888

8989
const list = document.querySelector('task-lists')
90-
list.addEventListener('task-lists:check', function(event) {
90+
list.addEventListener('task-lists-check', function(event) {
9191
called = true
9292
const {position, checked} = event.detail
9393
assert.deepEqual(position, [4, 0])

0 commit comments

Comments
 (0)