Skip to content

Commit 805146b

Browse files
committed
Fixup to address CI Issues
- Bump latest esbuild version explicity - Set CI Node to VSCode 1.98.0 Node Version - Fixup vscode tooling and enable format-on-save - Apply prettier configuration for whitespace remediation - Suppress new typescript warnings from newer TS version, to be fixed later
1 parent d4f407b commit 805146b

24 files changed

+758
-573
lines changed

.github/workflows/build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- uses: actions/checkout@v4
1818
- uses: actions/setup-node@v4
1919
with:
20-
node-version: 16.x
20+
node-version: 20.x
2121
cache: "npm"
2222
registry-url: "https://npm.pkg.github.com"
2323
- run: npm ci

.gitignore

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ dist
44
*.vsix
55
.DS_Store
66
runners
7-
.yalc
7+
.yalc
8+
.vscode-test-web

.prettierrc.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@
55
"singleQuote": false,
66
"bracketSpacing": false,
77
"trailingComma": "none",
8-
"arrowParens": "avoid"
8+
"arrowParens": "avoid",
9+
"semi": true
910
}

.vscode/extensions.json

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"recommendations": [
3+
"dbaeumer.vscode-eslint",
4+
"esbenp.prettier-vscode"
5+
]
6+
}

.vscode/settings.json

+10-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
{
2-
"github-actions.workflows.pinned.workflows": [".github/workflows/build.yml"],
3-
"editor.formatOnSave": true,
42
"[typescript]": {
5-
"editor.defaultFormatter": "esbenp.prettier-vscode"
3+
"editor.defaultFormatter": "esbenp.prettier-vscode",
4+
"editor.formatOnPaste": true,
5+
"editor.formatOnSave": true,
6+
"editor.formatOnSaveMode": "modificationsIfAvailable",
7+
"editor.codeActionsOnSave": {
8+
"source.fixAll.eslint": "explicit",
9+
"source.fixAll.ts": "explicit",
10+
"source.organizeImports.ts": "explicit",
11+
"source.addMissingImports.ts": "explicit"
12+
}
613
}
714
}

eslint.config.mjs

+14
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,22 @@
22

33
import eslint from '@eslint/js';
44
import tseslint from 'typescript-eslint';
5+
import eslintConfigPrettier from "eslint-config-prettier/flat"
56

67
export default tseslint.config(
78
eslint.configs.recommended,
89
tseslint.configs.recommended,
10+
// Ignores formatting rules that will be handled by Prettier
11+
eslintConfigPrettier,
12+
{
13+
name: "globalignores",
14+
ignores: [
15+
'**/node_modules/**',
16+
'jest.config.js',
17+
'src/external/**',
18+
'.vscode-test-web/**',
19+
'dist/**',
20+
'out/**'
21+
]
22+
}
923
);

0 commit comments

Comments
 (0)