From a7fe866523ab616f47df2d892b9a3acac329f821 Mon Sep 17 00:00:00 2001
From: Simon Weimann <simon.weimann@ruv.de>
Date: Thu, 23 May 2024 11:19:53 +0200
Subject: [PATCH] add member_role_id for saml group link (#1126)

---
 src/main/java/org/gitlab4j/api/GroupApi.java  | 42 +++++++++++++++++--
 .../gitlab4j/api/models/SamlGroupLink.java    | 10 +++++
 .../org/gitlab4j/api/saml-group-link.json     |  3 +-
 3 files changed, 51 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/gitlab4j/api/GroupApi.java b/src/main/java/org/gitlab4j/api/GroupApi.java
index 57d87aadb..d7d66ca27 100644
--- a/src/main/java/org/gitlab4j/api/GroupApi.java
+++ b/src/main/java/org/gitlab4j/api/GroupApi.java
@@ -1315,6 +1315,26 @@ public void addSamlGroupLink(Object groupIdOrPath, String samlGroupName, AccessL
         addSamlGroupLink(groupIdOrPath, samlGroupName, groupAccess.toValue());
     }
 
+     /**
+     * Adds an SAML group link.
+     *
+     * <pre><code>GitLab Endpoint: POST /groups/:id/saml_group_links</code></pre>
+     *
+     * @param groupIdOrPath the group ID, path of the group, or a Group instance holding the group ID or path
+     * @param samlGroupName the name of the SAML group
+     * @param groupAccess the minimum access level for members of the SAML group
+     * @param memberRoleId the id of the custom member role to assign
+     * @throws GitLabApiException if any exception occurs
+     */
+    public void addSamlGroupLink(Object groupIdOrPath, String samlGroupName, AccessLevel groupAccess, int memberRoleId) throws GitLabApiException {
+
+        if (groupAccess == null) {
+            throw new RuntimeException("groupAccess cannot be null or empty");
+        }
+
+        addSamlGroupLink(groupIdOrPath, samlGroupName, groupAccess.toValue(), memberRoleId);
+    }
+
     /**
      * Adds an SAML group link.
      *
@@ -1326,9 +1346,25 @@ public void addSamlGroupLink(Object groupIdOrPath, String samlGroupName, AccessL
      * @throws GitLabApiException if any exception occurs
      */
     public void addSamlGroupLink(Object groupIdOrPath, String samlGroupName, Integer groupAccess) throws GitLabApiException {
+        addSamlGroupLink(groupIdOrPath, samlGroupName, groupAccess, null);
+    }
+
+    /**
+     * Adds an SAML group link.
+     *
+     * <pre><code>GitLab Endpoint: POST /groups/:id/saml_group_links</code></pre>
+     *
+     * @param groupIdOrPath the group ID, path of the group, or a Group instance holding the group ID or path
+     * @param samlGroupName the name of the SAML group
+     * @param groupAccess the minimum access level for members of the SAML group
+     * @param memberRoleId the id of the custom member role to assign
+     * @throws GitLabApiException if any exception occurs
+     */
+    public void addSamlGroupLink(Object groupIdOrPath, String samlGroupName, Integer groupAccess, Integer memberRoleId) throws GitLabApiException {
         GitLabApiForm formData = new GitLabApiForm()
             .withParam("saml_group_name",  samlGroupName, true)
-            .withParam("access_level", groupAccess, true);
+            .withParam("access_level", groupAccess, true)
+            .withParam("member_role_id", memberRoleId);
         post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "saml_group_links");
     }
 
@@ -1888,7 +1924,7 @@ public Group setGroupAvatar(Object groupIdOrPath, File avatarFile) throws GitLab
      * Only working with GitLab 14.0 and above.
      *
      * <pre><code>GitLab Endpoint: GET /groups/:id/avatar</code></pre>
-     * 
+     *
      * @param groupIdOrPath the group ID, path of the group, or a Group instance holding the group ID or path
      * @return an InputStream to read the raw file from
      * @throws GitLabApiException if any exception occurs
@@ -2141,7 +2177,7 @@ public GroupAccessToken createGroupAccessToken(Object groupIdOrPath, String name
     public GroupAccessToken rotateGroupAccessToken(Object groupIdOrPath, Long tokenId) throws GitLabApiException {
         return rotateGroupAccessToken(groupIdOrPath, tokenId, null);
     }
-    
+
 
     /**
      * Rotate a group access token. Revokes the previous token and creates a new token that expires in one week.
diff --git a/src/main/java/org/gitlab4j/api/models/SamlGroupLink.java b/src/main/java/org/gitlab4j/api/models/SamlGroupLink.java
index b7fbdbabc..e5d959662 100644
--- a/src/main/java/org/gitlab4j/api/models/SamlGroupLink.java
+++ b/src/main/java/org/gitlab4j/api/models/SamlGroupLink.java
@@ -12,6 +12,8 @@ public class SamlGroupLink implements Serializable {
 
     private AccessLevel accessLevel;
 
+    private int memberRoleId;
+
     public String getName() {
         return name;
     }
@@ -28,6 +30,14 @@ public void setAccessLevel(AccessLevel aAccessLevel) {
         accessLevel = aAccessLevel;
     }
 
+    public int getMemberRoleId() {
+        return memberRoleId;
+    }
+
+    public void setMemberRoleId(int aMemberRoleId) {
+        memberRoleId = aMemberRoleId;
+    }
+
     @Override
     public String toString() {
         return (JacksonJson.toJsonString(this));
diff --git a/src/test/resources/org/gitlab4j/api/saml-group-link.json b/src/test/resources/org/gitlab4j/api/saml-group-link.json
index 38dce0873..0f01c1f3e 100644
--- a/src/test/resources/org/gitlab4j/api/saml-group-link.json
+++ b/src/test/resources/org/gitlab4j/api/saml-group-link.json
@@ -1,4 +1,5 @@
 {
     "access_level": 30,
-    "name": "A_GITLAB_DEVELOPER"
+    "name": "A_GITLAB_DEVELOPER",
+    "member_role_id": 6
 }