Skip to content

Commit c5b3acc

Browse files
stanhuashmckenzie
andcommitted
Merge branch '605-upgrade-to-ruby-3-x' into 'main'
Resolve "Upgrade to Ruby 3.x" Closes #605 See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/706 Merged-by: Stan Hu <[email protected]> Approved-by: James Fargher <[email protected]> Approved-by: Stan Hu <[email protected]> Reviewed-by: Ash McKenzie <[email protected]> Co-authored-by: Ash McKenzie <[email protected]>
2 parents 977a7e8 + e187403 commit c5b3acc

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed

.gitlab-ci.yml

+7-6
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ include:
1010
variables:
1111
DOCKER_VERSION: "20.10.15"
1212
BUNDLE_FROZEN: "true"
13-
GO_VERSION: "1.18"
13+
GO_VERSION: "golang-1.18"
1414
DEBIAN_VERSION: "bullseye"
15-
RUBY_VERSION: "2.7"
15+
RUBY_VERSION: "ruby-2.7"
1616

1717
workflow:
1818
rules: &workflow_rules
@@ -24,7 +24,7 @@ workflow:
2424
- if: '$CI_COMMIT_TAG'
2525

2626
default:
27-
image: registry.gitlab.com/gitlab-org/gitlab-build-images/debian-${DEBIAN_VERSION}-ruby-${RUBY_VERSION}-golang-${GO_VERSION}:git-2.36
27+
image: registry.gitlab.com/gitlab-org/gitlab-build-images/debian-${DEBIAN_VERSION}-${RUBY_VERSION}-${GO_VERSION}:git-2.36
2828
tags:
2929
- gitlab-org
3030

@@ -51,14 +51,15 @@ default:
5151
# Disable the hooks so we don't have to stub the GitLab API
5252
command: ["bash", "-c", "mkdir -p /home/git/repositories && rm -rf /srv/gitlab-shell/hooks/* && exec /usr/bin/env GITALY_TESTING_NO_GIT_HOOKS=1 /scripts/process-wrapper"]
5353
alias: gitaly
54-
script:
55-
- make verify test
5654

5755
tests:
5856
extends: .test
5957
parallel:
6058
matrix:
61-
- GO_VERSION: ["1.17", "1.18", "1.19"]
59+
- GO_VERSION: ["golang-1.17", "golang-1.18", "golang-1.19"]
60+
- RUBY_VERSION: ["ruby-2.7", "ruby-3.0"]
61+
script:
62+
- make verify test
6263
after_script:
6364
- make coverage
6465
coverage: '/\d+.\d+%/'

.ruby-version

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.7.7
1+
3.0.5

.tool-versions

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
ruby 2.7.7
1+
ruby 3.0.5
22
golang 1.18.7

Gemfile

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ source 'https://rubygems.org'
22

33
group :development, :test do
44
gem 'rspec', '~> 3.8.0'
5+
gem 'webrick', '~> 1.7'
56
end
67

78
group :development, :danger do

Gemfile.lock

+2
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,15 @@ GEM
104104
terminal-table (3.0.2)
105105
unicode-display_width (>= 1.1.1, < 3)
106106
unicode-display_width (2.2.0)
107+
webrick (1.7.0)
107108

108109
PLATFORMS
109110
ruby
110111

111112
DEPENDENCIES
112113
gitlab-dangerfiles (~> 3.5.1)
113114
rspec (~> 3.8.0)
115+
webrick (~> 1.7)
114116

115117
BUNDLED WITH
116118
2.3.15

0 commit comments

Comments
 (0)